This repository was archived by the owner on Feb 24, 2026. It is now read-only.
feature: add JsonStreamWriter, which is built on top of a StreamWriter and writes Json data by first converting to protobuf messages then calling StreamWriter's append#437
Merged
stephaniewang526 merged 41 commits intogoogleapis:masterfrom Aug 7, 2020
Conversation
760e8f0 to
73c5926
Compare
yirutang
reviewed
Jul 21, 2020
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Schema update part looks good.
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
Wilson720
suggested changes
Jul 22, 2020
Wilson720
left a comment
There was a problem hiding this comment.
Looks good overall. Have few comments.
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
6576179 to
cfcb01e
Compare
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
============================================
+ Coverage 78.00% 78.30% +0.29%
- Complexity 624 642 +18
============================================
Files 56 58 +2
Lines 3551 3687 +136
Branches 235 245 +10
============================================
+ Hits 2770 2887 +117
- Misses 675 687 +12
- Partials 106 113 +7
Continue to review full report at Codecov.
|
Wilson720
approved these changes
Jul 23, 2020
860e79a to
f14de23
Compare
yirutang
reviewed
Jul 24, 2020
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...test/java/com/google/cloud/bigquery/storage/v1alpha2/it/ITBigQueryWriteManualClientTest.java
Show resolved
Hide resolved
cb6edeb to
ea61eae
Compare
yirutang
reviewed
Jul 28, 2020
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Outdated
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Outdated
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Outdated
Show resolved
Hide resolved
Wilson720
reviewed
Jul 28, 2020
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/OnSchemaUpdateRunnable.java
Show resolved
Hide resolved
...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/OnSchemaUpdateRunnable.java
Outdated
Show resolved
Hide resolved
7d3da73 to
96007cb
Compare
Wilson720
approved these changes
Jul 29, 2020
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Show resolved
Hide resolved
...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/OnSchemaUpdateRunnable.java
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
yirutang
reviewed
Jul 30, 2020
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Outdated
Show resolved
Hide resolved
...rystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriterTest.java
Outdated
Show resolved
Hide resolved
...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/OnSchemaUpdateRunnable.java
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...rystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriterTest.java
Show resolved
Hide resolved
b99e348 to
5c092f3
Compare
yirutang
reviewed
Aug 4, 2020
...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/OnSchemaUpdateRunnable.java
Outdated
Show resolved
Hide resolved
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...rystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriterTest.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
Wilson720
reviewed
Aug 4, 2020
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
…e to be approved.
…t, and fixed refreshAppend in StreamWriter
… by letting StreamWriter handle sending first writer schema, added an additional lock between append and refreshAppend for StreamWriter
3538902 to
0230815
Compare
yirutang
reviewed
Aug 5, 2020
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
Outdated
Show resolved
Hide resolved
yirutang
reviewed
Aug 5, 2020
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
…ppend, flush, and setDescriptor.
yirutang
reviewed
Aug 6, 2020
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Looks good, only minor comments.
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
… made refreshConnection not public
yirutang
approved these changes
Aug 6, 2020
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
stephaniewang526
approved these changes
Aug 7, 2020
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
doclava v2 => staging docFX v3 => prod Source-Author: Emily Ball <emilyball@google.com> Source-Date: Tue Feb 16 17:02:08 2021 -0800 Source-Repo: googleapis/synthtool Source-Sha: b416a7befcdbc42de41cf387dcf428f894fb812b Source-Link: googleapis/synthtool@b416a7b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.