Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

refactor: Added Null checks for all object parameters for all public …#429

Merged
stephaniewang526 merged 5 commits intogoogleapis:masterfrom
allenc3:AddNullChecks
Jul 21, 2020
Merged

refactor: Added Null checks for all object parameters for all public …#429
stephaniewang526 merged 5 commits intogoogleapis:masterfrom
allenc3:AddNullChecks

Conversation

@allenc3
Copy link
Copy Markdown
Contributor

@allenc3 allenc3 commented Jul 17, 2020

…methods and renamed all instances of compact to compat.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2020

Codecov Report

Merging #429 into master will increase coverage by 0.07%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #429      +/-   ##
============================================
+ Coverage     77.20%   77.28%   +0.07%     
  Complexity      576      576              
============================================
  Files            55       55              
  Lines          3391     3407      +16     
  Branches        202      203       +1     
============================================
+ Hits           2618     2633      +15     
- Misses          668      669       +1     
  Partials        105      105              
Impacted Files Coverage Δ Complexity Δ
...bigquery/storage/v1alpha2/SchemaCompatibility.java 91.51% <57.14%> (+0.21%) 98.00 <4.00> (ø)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 80.36% <92.30%> (-0.01%) 33.00 <2.00> (ø)
...orage/v1alpha2/BQTableSchemaToProtoDescriptor.java 98.48% <100.00%> (+0.02%) 8.00 <1.00> (ø)
.../cloud/bigquery/storage/v1alpha2/DirectWriter.java 80.64% <100.00%> (+1.33%) 5.00 <2.00> (ø)
...e/cloud/bigquery/storage/v1alpha2/WriterCache.java 92.13% <100.00%> (+0.37%) 14.00 <6.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83b6b3...e20c03f. Read the comment docs.

@allenc3 allenc3 marked this pull request as ready for review July 21, 2020 17:11
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 21, 2020
@stephaniewang526 stephaniewang526 merged commit 112224b into googleapis:master Jul 21, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)

Fixes googleapis#352 ☕️
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants