Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

chore: add plumbing to allow customer to enable reporting OT metrics#2581

Merged
agrawal-siddharth merged 1 commit into
googleapis:mainfrom
agrawal-siddharth:metricsFlag
Jul 26, 2024
Merged

chore: add plumbing to allow customer to enable reporting OT metrics#2581
agrawal-siddharth merged 1 commit into
googleapis:mainfrom
agrawal-siddharth:metricsFlag

Conversation

@agrawal-siddharth

Copy link
Copy Markdown
Contributor

This change prepares for a future change that will actually consume the flag to enable/disable reporting of OpenTelemetry metrics.

@agrawal-siddharth agrawal-siddharth requested review from a team and farhan0102 July 26, 2024 16:56
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Jul 26, 2024

@yirutang yirutang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this flag actually used?

@agrawal-siddharth

agrawal-siddharth commented Jul 26, 2024

Copy link
Copy Markdown
Contributor Author

No, as yet the flag is not used. Next checkin will factor out the metrics reporting logic and will begin using it.

@agrawal-siddharth agrawal-siddharth merged commit 9839d4d into googleapis:main Jul 26, 2024
@agrawal-siddharth agrawal-siddharth deleted the metricsFlag branch August 14, 2024 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants