Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

chore: demonstrate exporting OpenTelemetry logs to Google Cloud#2573

Merged
agrawal-siddharth merged 1 commit into
googleapis:mainfrom
agrawal-siddharth:exportOT
Aug 30, 2024
Merged

chore: demonstrate exporting OpenTelemetry logs to Google Cloud#2573
agrawal-siddharth merged 1 commit into
googleapis:mainfrom
agrawal-siddharth:exportOT

Conversation

@agrawal-siddharth

@agrawal-siddharth agrawal-siddharth commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

Monitoring

@agrawal-siddharth agrawal-siddharth requested review from a team and shollyman July 22, 2024 23:54
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jul 22, 2024
@generated-files-bot

generated-files-bot Bot commented Jul 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label Bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jul 22, 2024
@agrawal-siddharth agrawal-siddharth force-pushed the exportOT branch 2 times, most recently from 5bf2c62 to 5b6cffa Compare July 23, 2024 19:16
@yirutang yirutang requested a review from PhongChuong July 23, 2024 21:37
yirutang
yirutang approved these changes Jul 23, 2024
View reviewed changes

@yirutang yirutang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for Java lib owner's approval.

PhongChuong
PhongChuong reviewed Jul 26, 2024
View reviewed changes

@PhongChuong PhongChuong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just some minor suggestions.

Comment thread samples/snippets/src/test/java/com/example/bigquerystorage/ExportOpenTelemetryIT.java
Comment thread samples/install-without-bom/pom.xml Outdated
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 15, 2024
@snippet-bot

snippet-bot Bot commented Aug 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@agrawal-siddharth agrawal-siddharth force-pushed the exportOT branch 6 times, most recently from 9aa5743 to ee97b19 Compare August 30, 2024 14:07
@agrawal-siddharth agrawal-siddharth merged commit 5852ea1 into googleapis:main Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shollyman shollyman Awaiting requested review from shollyman

2 more reviewers

@PhongChuong PhongChuong PhongChuong left review comments

@yirutang yirutang yirutang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agrawal-siddharth @yirutang @PhongChuong