Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

ci: javadoc job (JDK 17) in ci.yaml#2173

Merged
Neenu1995 merged 7 commits into
googleapis:mainfrom
suztomo:javadoc_job
Jun 28, 2023
Merged

ci: javadoc job (JDK 17) in ci.yaml#2173
Neenu1995 merged 7 commits into
googleapis:mainfrom
suztomo:javadoc_job

Conversation

@suztomo

@suztomo suztomo commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  • refactor: removing an unnecessary semicolon
  • ci: javadoc job (JDK 17) in ci.yaml

Because owlbot.py has ci.yaml, I create this PR manually. This PR resolves the following javadoc errors:

[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java:111: error: unknown tag: AppendRowsResponse
[ERROR]    * @return ApiFuture<AppendRowsResponse> returns an AppendRowsResponse message wrapped in an
[ERROR]                       ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java:181: error: unknown tag: AppendRowsResponse
[ERROR]    * @return ApiFuture<AppendRowsResponse> returns an AppendRowsResponse message wrapped in an
[ERROR]                       ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java:86: error: unknown tag: AppendRowsResponse
[ERROR]    * @return ApiFuture<AppendRowsResponse> returns an AppendRowsResponse message wrapped in an
[ERROR]                       ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java:99: error: unknown tag: AppendRowsResponse
[ERROR]    * @return ApiFuture<AppendRowsResponse> returns an AppendRowsResponse message wrapped in an
[ERROR]                       ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java:573: error: unknown tag: Deprecated
[ERROR]      * @Deprecated Setter for a reconnectAfter10M, temporaily workaround for omg/48020. Fix for the
[ERROR]        ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java:494: error: reference not found
[ERROR]   /** Constructs a new {@link StreamWriterV2.Builder} using the given stream and client. */
[ERROR]                               ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java:499: error: reference not found
[ERROR]   /** Constructs a new {@link StreamWriterV2.Builder} using the given stream. */
[ERROR]                               ^


[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java:219: error: reference not found
[ERROR]    * This exception is thrown from {@link JsonStreamWriter#append()} when the client side Json to
[ERROR]                                           ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/CivilTimeEncoder.java:42: error: no caption for table
[ERROR]  * </table>
[ERROR]    ^
[ERROR] /usr/local/google/home/suztomo/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/CivilTimeEncoder.java:42: error: no caption for table
[ERROR]  * </table>
[ERROR]    ^

@suztomo suztomo requested review from a team and obada-ab June 28, 2023 18:38
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Jun 28, 2023
@generated-files-bot

generated-files-bot Bot commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/MockBigQueryStorageImpl.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/MockBigQueryWriteImpl.java
  • proto-google-cloud-bigquerystorage-v1beta1/src/main/java/com/google/cloud/bigquery/storage/v1beta1/ReadOptions.java
  • proto-google-cloud-bigquerystorage-v1beta1/src/main/java/com/google/cloud/bigquery/storage/v1beta1/Storage.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamProto.java

@product-auto-label product-auto-label Bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jun 28, 2023
@suztomo
ci: javadoc job (JDK 17) in ci.yaml
9e97f70 
This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jun 28, 2023
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jun 28, 2023
suztomo
suztomo commented Jun 28, 2023
View reviewed changes
Comment thread .github/workflows/ci.yaml
Comment on lines +73 to +84
javadoc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
- run: java -version
- run: .kokoro/build.sh
env:
JOB_TYPE: javadoc

@suztomo suztomo Jun 28, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change.

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@Neenu1995 Neenu1995 merged commit c7e5ef6 into googleapis:main Jun 28, 2023
@suztomo suztomo deleted the javadoc_job branch June 28, 2023 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@obada-ab obada-ab Awaiting requested review from obada-ab

1 more reviewer

@Neenu1995 Neenu1995 Neenu1995 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo @Neenu1995