Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit #2084

Merged
GaoleMeng merged 11 commits into
googleapis:mainfrom
GaoleMeng:main
Apr 25, 2023
Merged

fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit #2084
GaoleMeng merged 11 commits into
googleapis:mainfrom
GaoleMeng:main

Conversation

@GaoleMeng

Copy link
Copy Markdown
Contributor

Since write api server side per request timeout is 2 minutes, it does not make sense to wait 15 minutes to determine whether a connection has been dead, reducing it to 3 minutes

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@GaoleMeng GaoleMeng requested review from a team and prash-mi April 22, 2023 00:52
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Apr 22, 2023
@GaoleMeng GaoleMeng changed the title fix: Reduce timeout of waiting in queue from 15 minutes to 3 minutes fix: Reduce timeout of waiting in queue from 15 minutes to 3 minutes and rephrase the log a bit Apr 22, 2023
@GaoleMeng GaoleMeng requested a review from yirutang April 22, 2023 00:54
…eue.

Since in write api server side we have total timeout of 2 minutes, it
does not make sense to wait 15 minutes to determine whether we have met
dead connection, let's reduce the timeout here
@GaoleMeng GaoleMeng changed the title fix: Reduce timeout of waiting in queue from 15 minutes to 3 minutes and rephrase the log a bit fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit Apr 22, 2023
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team April 25, 2023 00:18
@GaoleMeng GaoleMeng merged commit fe25f38 into googleapis:main Apr 25, 2023
gcf-merge-on-green Bot pushed a commit that referenced this pull request Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants