Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric#2031

Merged
gcf-merge-on-green[bot] merged 2 commits into
mainfrom
unknown repository
Mar 8, 2023
Merged

fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric#2031
gcf-merge-on-green[bot] merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 8, 2023

Copy link
Copy Markdown
  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2013

@ghost ghost requested review from a team and chalmerlowe March 8, 2023 08:51
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 8, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team March 8, 2023 15:17
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 8, 2023
@Neenu1995

Copy link
Copy Markdown
Contributor

Hi @roy-tc ,

That worked!
Thanks again for contributing.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023
@ghost

ghost commented Mar 8, 2023

Copy link
Copy Markdown
Author

Thanks for the efforts @Neenu1995 ! Looking forward to the release.

@gcf-merge-on-green

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit e0f7e34 into googleapis:main Mar 8, 2023
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery Storage Write API: JsonStreamWriter cannot transform BigDecimal with 9+ decimals to BigNumeric

3 participants