This repository was archived by the owner on Feb 24, 2026. It is now read-only.
feat(shortsAndBigDecimals): add shorts and big decimals#1674
Merged
Neenu1995 merged 3 commits intogoogleapis:mainfrom Oct 17, 2022
dark0dave:feature/shortsAndBigDecimalsAsBigDecimals
Merged
feat(shortsAndBigDecimals): add shorts and big decimals#1674Neenu1995 merged 3 commits intogoogleapis:mainfrom dark0dave:feature/shortsAndBigDecimalsAsBigDecimals
Neenu1995 merged 3 commits intogoogleapis:mainfrom
dark0dave:feature/shortsAndBigDecimalsAsBigDecimals
Conversation
yirutang
reviewed
Jul 26, 2022
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Looks good to me. Just add some unit test to capture the fixes.
Contributor
Author
|
@yirutang tests added, ready for review |
Signed-off-by: dark0dave <dark0dave@mykolab.com>
yirutang
reviewed
Aug 15, 2022
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Looks good, thanks. Is BigDecimal case covered?
Neenu1995
reviewed
Aug 15, 2022
| .setMode(TableFieldSchema.Mode.NULLABLE) | ||
| .setName("test_numeric_str") | ||
| .build(); | ||
| final TableFieldSchema TEST_NUMERIC_SHORT = |
Contributor
There was a problem hiding this comment.
Since only the v1 client is updated, v1beta2 tests are not needed. Can you please remove this?
Contributor
Author
There was a problem hiding this comment.
I can, I wanted to maintain backwards compat, but if thats not an issue I will change
yirutang
reviewed
Aug 15, 2022
...ystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/JsonToProtoMessageTest.java
Show resolved
Hide resolved
yirutang
reviewed
Aug 24, 2022
yirutang
approved these changes
Oct 17, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
🤖 I have created a release *beep* *boop* --- ## [2.24.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.23.1...v2.24.0) (2022-10-25) ### Features * Add getInflightWaitSeconds implementation ([#1835](https://togithub.com/googleapis/java-bigquerystorage/issues/1835)) ([b569116](https://togithub.com/googleapis/java-bigquerystorage/commit/b569116179700123e405eb7712abb136456f2f26)) * **shortsAndBigDecimals:** Add shorts and big decimals ([#1674](https://togithub.com/googleapis/java-bigquerystorage/issues/1674)) ([604d7df](https://togithub.com/googleapis/java-bigquerystorage/commit/604d7df2afa54e445a4d310e5293d8d19901d565)) ### Bug Fixes * **java:** Restore native image configurations ([#1844](https://togithub.com/googleapis/java-bigquerystorage/issues/1844)) ([8ce670a](https://togithub.com/googleapis/java-bigquerystorage/commit/8ce670a487a192807ccfd58613fc271d9402ca7c)) * Remove the client lib header setting since after router migration, it is no longer needed ([#1842](https://togithub.com/googleapis/java-bigquerystorage/issues/1842)) ([5f3b821](https://togithub.com/googleapis/java-bigquerystorage/commit/5f3b8214116b17b315d589bfde184e0e045cff69)) ### Dependencies * Update dependency com.google.auto.value:auto-value to v1.10 ([#1825](https://togithub.com/googleapis/java-bigquerystorage/issues/1825)) ([f7b8f2b](https://togithub.com/googleapis/java-bigquerystorage/commit/f7b8f2b4df8ca9b306a75d46eb223124ac9bdebb)) * Update dependency com.google.auto.value:auto-value-annotations to v1.10 ([#1826](https://togithub.com/googleapis/java-bigquerystorage/issues/1826)) ([37eb8a1](https://togithub.com/googleapis/java-bigquerystorage/commit/37eb8a1df34e8ae4d5e2849c76d9a591ec5505d4)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.17.1 ([#1829](https://togithub.com/googleapis/java-bigquerystorage/issues/1829)) ([7e8d900](https://togithub.com/googleapis/java-bigquerystorage/commit/7e8d90037f5ae426882f90ab251d315767b3a6b7)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#1840](https://togithub.com/googleapis/java-bigquerystorage/issues/1840)) ([474756b](https://togithub.com/googleapis/java-bigquerystorage/commit/474756bd6547254ed6d761a73f2e69920fa79458)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
gcf-owl-bot bot
added a commit
that referenced
this pull request
Oct 28, 2022
Revert "chore(deps): update dependency protobuf to v3.20.2 (#1659)" This reverts commit b59cf7b5a91ecab29e21fdfbb7e3b81066229be4. Source-Link: googleapis/synthtool@a66e346 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd316b9a591c45264775ecaba72e37d65905925c323b68e51a08c4126e4b6d0a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dark0dave dark0dave@mykolab.com
Closes #1673