This repository was archived by the owner on Feb 24, 2026. It is now read-only.
fix: change customer StorageException from RuntimeException to StatusRuntimeException#1559
Merged
stephaniewang526 merged 9 commits intogoogleapis:mainfrom Mar 3, 2022
Merged
Conversation
4180915 to
3030f38
Compare
…RuntimeException so that Beam connector can consume it.
81fcc27 to
8ac46cb
Compare
yirutang
reviewed
Mar 2, 2022
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Outdated
Show resolved
Hide resolved
yirutang
reviewed
Mar 2, 2022
Contributor
yirutang
left a comment
There was a problem hiding this comment.
One Line 133. How about rpcStatus is null?
I think we should add a unit case trying the toStorageEexception with a random Exception.
Contributor
Author
Added a negative test to verify behavior when we get a non-StatusRuntimeException. |
yirutang
reviewed
Mar 3, 2022
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Outdated
Show resolved
Hide resolved
...oud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java
Outdated
Show resolved
Hide resolved
yirutang
reviewed
Mar 3, 2022
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Outdated
Show resolved
Hide resolved
yirutang
reviewed
Mar 3, 2022
...e/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryWriteManualClientTest.java
Show resolved
Hide resolved
yirutang
approved these changes
Mar 3, 2022
tswast
approved these changes
Mar 3, 2022
tswast
left a comment
There was a problem hiding this comment.
LGTM since StatusRuntimeException extends RuntimeException and only private/protected constructors are breaking.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 4, 2022
🤖 I have created a release *beep* *boop* --- ### [2.10.1](v2.10.0...v2.10.1) (2022-03-03) ### Bug Fixes * change customer StorageException from RuntimeException to StatusRuntimeException ([#1559](#1559)) ([523377e](523377e)) ### Dependencies * update actions/checkout action to v3 ([#1554](#1554)) ([1371ac9](1371ac9)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.8.0 ([#1555](#1555)) ([cc25162](cc25162)) ### Documentation * improve documentation for write client ([#1560](#1560)) ([fbb5321](fbb5321)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that Beam connector can consume it.
(related to: apache/beam@85268dd)