Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat: add BIGNUMERIC support#703

Merged
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:masterfrom
stephaniewang526:bignumeric
Nov 19, 2020
Merged

feat: add BIGNUMERIC support#703
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:masterfrom
stephaniewang526:bignumeric

Conversation

@stephaniewang526
Copy link
Copy Markdown
Contributor

@stephaniewang526 stephaniewang526 commented Aug 27, 2020 •
edited
Loading

Expose BIGNUMERIC type in the client

cc: @MingyuZhong

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2020
@stephaniewang526 stephaniewang526 marked this pull request as draft August 27, 2020 19:18
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Aug 28, 2020
@stephaniewang526
feat: add BIGNUMERIC support
f021dde 
update IT testcase

nit
@stephaniewang526 stephaniewang526 marked this pull request as ready for review August 28, 2020 16:23
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #703 (f021dde) into master (f59241b) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #703      +/-   ##
============================================
+ Coverage     80.40%   81.07%   +0.67%     
+ Complexity     1271     1237      -34     
============================================
  Files            79       78       -1     
  Lines          6573     6336     -237     
  Branches        758      703      -55     
============================================
- Hits           5285     5137     -148     
+ Misses          893      833      -60     
+ Partials        395      366      -29
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/bigquery/LegacySQLTypeName.java 95.34% <100.00%> (+0.22%) 7.00 <0.00> (ø)
...com/google/cloud/bigquery/QueryParameterValue.java 81.86% <100.00%> (+0.08%) 61.00 <1.00> (+1.00)
...com/google/cloud/bigquery/StandardSQLTypeName.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...google/cloud/bigquery/HivePartitioningOptions.java 83.78% <0.00%> (-1.64%) 11.00% <0.00%> (-2.00%)
...y/src/main/java/com/google/cloud/bigquery/Acl.java 71.42% <0.00%> (-0.58%) 13.00% <0.00%> (-1.00%)
...google/cloud/bigquery/ExternalTableDefinition.java 58.09% <0.00%> (-0.47%) 19.00% <0.00%> (-2.00%)
...m/google/cloud/bigquery/QueryJobConfiguration.java 90.08% <0.00%> (-0.27%) 66.00% <0.00%> (-2.00%)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 82.84% <0.00%> (-0.24%) 77.00% <0.00%> (-9.00%)
...main/java/com/google/cloud/bigquery/FieldList.java 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/TimePartitioning.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59241b...f517a6b. Read the comment docs.

MingyuZhong
MingyuZhong approved these changes Aug 28, 2020
View reviewed changes
Copy link
Copy Markdown

@MingyuZhong MingyuZhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephaniewang526 stephaniewang526 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 28, 2020
@stephaniewang526
Copy link
Copy Markdown
Contributor Author

stephaniewang526 commented Aug 28, 2020

Cannot merge until BigQuery backend is ready.

@shollyman
Copy link
Copy Markdown
Contributor

shollyman commented Nov 19, 2020

Modulo any updates bringing this PR back in line with master, this should be good to merge now.

@stephaniewang526 stephaniewang526 requested a review from a team November 19, 2020 20:23
@stephaniewang526 stephaniewang526 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 19, 2020
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 19, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 718ec2a into googleapis:master Nov 19, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 19, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 19, 2020
@release-please
chore: release 1.125.0 (#962)
cc1db90 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.125.0](https://www.github.com/googleapis/java-bigquery/compare/v1.124.7...v1.125.0) (2020-11-19)


### Features

* add BIGNUMERIC support ([#703](https://www.github.com/googleapis/java-bigquery/issues/703)) ([718ec2a](https://www.github.com/googleapis/java-bigquery/commit/718ec2ae25150dceef8fb9bc3e2fcf6238fc2220))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@shollyman shollyman shollyman approved these changes

@pmakani pmakani pmakani approved these changes

@MingyuZhong MingyuZhong MingyuZhong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephaniewang526 @shollyman @pmakani @MingyuZhong