Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

chore: add UUID to retry logging#1581

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
franklinWhaite:master
Sep 17, 2021
Merged

chore: add UUID to retry logging#1581
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
franklinWhaite:master

Conversation

@franklinWhaite
Copy link
Copy Markdown
Contributor

@franklinWhaite franklinWhaite commented Sep 15, 2021

No description provided.

@franklinWhaite franklinWhaite requested review from a team and loferris September 15, 2021 21:28
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Sep 15, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2021
stephaniewang526
stephaniewang526 suggested changes Sep 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Franklin, this looks good in general. Two lint:

  1. rename initial commit to chore: add UUID to retry logging
  2. run mvn com.coveo:fmt-maven-plugin:format and push the change to clear the lint error

@stephaniewang526 stephaniewang526 changed the title Adding identifier to retry log chore: add UUID to retry logging Sep 17, 2021
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2021
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 17, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e384f5a into googleapis:master Sep 17, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferris loferris Awaiting requested review from loferris

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@franklinWhaite @stephaniewang526 @yoshi-kokoro