chore(php): set Compute migration_mode to MIGRATING #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
See googleapis/google-cloud-php#7907 for a preview of the changes |
Contributor
Author
|
@noahdietz do you have permission to approve/merge this? |
noahdietz
approved these changes
Dec 11, 2024
Contributor
I do! And done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other
BUILDfiles for PHP have long since been updated withmigration_mode=MIGRATINGor evenmigration_mode=NEW_SURFACE_ONLY, but this one was missed because it's canonical source is here (I would suggest that it should be inthird_partywith the rest of the APIs, so that this is less likely to happen).We want to move the compute library for PHP to
NEW_SURFACE_ONLY, but I'd like to create at least one release of the compute library with the migration_mode set toMIGRATINGfirst. The difference here is that the previous surfaces are marked as deprecated, and the samples use the new surface.