docs(Compute): update samples to use new surface #7907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07fb9a4 to
43fb566
Compare
iennae
approved these changes
Dec 10, 2024
Contributor
iennae
left a comment
There was a problem hiding this comment.
LGTM;
Separate from this, I think the CODEOWNERS is incorrect as CICD probably shouldn't get tagged for all the things :) but feels like that's a bigger lift figuring out the right teams as I'm guessing from a samples perspective there isn't the equivalent setup right now in googleapis as GoogleCloudPlatform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new surface clients for compute samples and link to them in the documentation