Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 28, 2019

Closes #63.

@tseaver tseaver requested review from busunkim96 and crwilcox August 28, 2019 15:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Aug 28, 2019

@busunkim96, @crwilcox The resumable upload docs state that valid initiation responses will be 200s, with a Location header. This PR change asserts the status code, so that the error we raise won't mask non-200s.

@tseaver tseaver merged commit d278abb into googleapis:master Aug 28, 2019
@tseaver tseaver deleted the 63-require-200-for-initial-resumable-response branch August 28, 2019 19:22
bors bot added a commit to mozilla/normandy that referenced this pull request Sep 11, 2019
1977: Scheduled weekly dependency update for week 36 r=rehandalal a=pyup-bot






### Update [botocore](https://pypi.org/project/botocore) from **1.12.220** to **1.12.224**.


<details>
  <summary>Changelog</summary>
  
  
   ### 1.12.224
   ```
   ========

* api-change:``kinesisanalytics``: Update kinesisanalytics client to latest version
   ```
   
  
  
   ### 1.12.223
   ```
   ========

* api-change:``config``: Update config client to latest version
   ```
   
  
  
   ### 1.12.222
   ```
   ========

* api-change:``stepfunctions``: Update stepfunctions client to latest version
* api-change:``transcribe``: Update transcribe client to latest version
* api-change:``eks``: Update eks client to latest version
   ```
   
  
  
   ### 1.12.221
   ```
   ========

* api-change:``ecs``: Update ecs client to latest version
* api-change:``resourcegroupstaggingapi``: Update resourcegroupstaggingapi client to latest version
* api-change:``gamelift``: Update gamelift client to latest version
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/botocore
  - Changelog: https://pyup.io/changelogs/botocore/
  - Repo: https://github.com/boto/botocore
</details>





### Update [google-resumable-media](https://pypi.org/project/google-resumable-media) from **0.3.3** to **0.4.0**.


<details>
  <summary>Changelog</summary>
  
  
   ### 0.4.0
   ```
   09-05-2019 11:59 PDT

 Backward-Compatibility Note

The change to use raw response data (PR
[87](googleapis/google-resumable-media-python#87))
might break the hypothetical usecase of downloading a blob marked with
`Content-Encoding: gzip` and expecting to get the expanded data.

 Implementation Changes
- Require 200 response for initial resumable upload request. ([95](googleapis/google-resumable-media-python#95))
- Use `response` as variable for object returned from `http_request`. ([98](googleapis/google-resumable-media-python#98))
- Further DRY request dependency pins. ([96](googleapis/google-resumable-media-python#96))
- Finish download on seeing 416 response with zero byte range. ([86](googleapis/google-resumable-media-python#86))
- Always use raw response data. ([87](googleapis/google-resumable-media-python#87))

 Dependencies
- Drop runtime dependency check on `requests`. ([97](googleapis/google-resumable-media-python#97))

 Documentation
- Update docs after release ([93](googleapis/google-resumable-media-python#93))
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/google-resumable-media
  - Changelog: https://pyup.io/changelogs/google-resumable-media/
  - Repo: https://github.com/GoogleCloudPlatform/google-resumable-media-python
</details>





### Update [snowballstemmer](https://pypi.org/project/snowballstemmer) from **1.9.0** to **1.9.1**.


*The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)*

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/snowballstemmer
  - Repo: https://github.com/snowballstem/snowball
</details>





### Update [boto3](https://pypi.org/project/boto3) from **1.9.220** to **1.9.224**.


<details>
  <summary>Changelog</summary>
  
  
   ### 1.9.224
   ```
   =======

* api-change:``kinesisanalytics``: [``botocore``] Update kinesisanalytics client to latest version
   ```
   
  
  
   ### 1.9.223
   ```
   =======

* api-change:``config``: [``botocore``] Update config client to latest version
   ```
   
  
  
   ### 1.9.222
   ```
   =======

* api-change:``stepfunctions``: [``botocore``] Update stepfunctions client to latest version
* api-change:``transcribe``: [``botocore``] Update transcribe client to latest version
* api-change:``eks``: [``botocore``] Update eks client to latest version
   ```
   
  
  
   ### 1.9.221
   ```
   =======

* api-change:``ecs``: [``botocore``] Update ecs client to latest version
* api-change:``resourcegroupstaggingapi``: [``botocore``] Update resourcegroupstaggingapi client to latest version
* api-change:``gamelift``: [``botocore``] Update gamelift client to latest version
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/boto3
  - Changelog: https://pyup.io/changelogs/boto3/
  - Repo: https://github.com/boto/boto3
</details>





### Update [djangorestframework](https://pypi.org/project/djangorestframework) from **3.10.2** to **3.10.3**.


*The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)*

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/djangorestframework
  - Changelog: https://pyup.io/changelogs/djangorestframework/
  - Homepage: https://www.django-rest-framework.org/
</details>





### Update [Werkzeug](https://pypi.org/project/Werkzeug) from **0.15.5** to **0.15.6**.


<details>
  <summary>Changelog</summary>
  
  
   ### 0.15.6
   ```
   --------------

Released 2019-09-04

-   Work around a bug in pip that caused the reloader to fail on
    Windows when the script was an entry point. This fixes the issue
    with Flask&#39;s `flask run` command failing with &quot;No module named
    Scripts\flask&quot;. :issue:`1614`
-   ``ProxyFix`` trusts the ``X-Forwarded-Proto`` header by default.
    :issue:`1630`
-   The deprecated ``num_proxies`` argument to ``ProxyFix`` sets
    ``x_for``, ``x_proto``, and ``x_host`` to match 0.14 behavior. This
    is intended to make intermediate upgrades less disruptive, but the
    argument will still be removed in 1.0. :issue:`1630`
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/werkzeug
  - Changelog: https://pyup.io/changelogs/werkzeug/
  - Homepage: https://palletsprojects.com/p/werkzeug/
</details>







Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initiate Response failing due to no Location header in response

2 participants