fix: add retry coverage to the streaming portion of a download #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsg
approved these changes
Jul 27, 2021
Contributor
andrewsg
left a comment
There was a problem hiding this comment.
Thanks for this awesome work!
cojenco
added a commit
to cojenco/google-resumable-media-python
that referenced
this pull request
Jul 30, 2021
googleapis#241)" This reverts commit cc1f07c.
cojenco
added a commit
to cojenco/google-resumable-media-python
that referenced
this pull request
Jul 30, 2021
…wnload (googleapis#241)" This reverts commit cc1f07c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broadens the retry coverage in downloads to cover both the initial response (receiving/evaluating http headers) and the streaming/writing to file portion of the download.
consume()method to an internal method_consume()and replace the retry-able http request to a raw http requestconsume_with_retries()within classesDownloadandChunkedDownloadthat will attempt to retry a callable_consume()until successFixes #240