fix(pubsub): default shutdown behavior#5110
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Mar 24, 2026
Merged
Conversation
Member
Author
|
/gcbrun(cf66c8e) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5110 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 215 215
Lines 41719 41719
=======================================
Hits 40663 40663
Misses 1056 1056 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Mar 24, 2026
Collaborator
coryan
left a comment
There was a problem hiding this comment.
If you are blocked, here is a LGTM, the code looks safe. If you want real feedback maybe wait for a different reviewer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4869
Change the default shutdown behavior to wait until the application has consumed all of its ack handlers.