Skip to content

Default shutdown behavior for message streams #4869

@dbolduc

Description

@dbolduc

Related to #4868

The default shutdown behavior should be WaitForProcessing from #4868. We have something closer to NackImmediately.

We should change the implementation so that WaitForProcessing is the default. That leads to the best customer experience.

Note that this issue tracks setting the default behavior, not making the shutdown behavior configurable.

It will take non-trivial changes to accomplish this. The lease loop needs to exit, not when message_tx is dropped, but when the last ack_tx is dropped.

None => break shutdown(state, ack_rx).await,

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the Pub/Sub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions