docs: Generate QuickStart samples#4844
Merged
amanda-tarafa merged 1 commit intogoogleapis:mainfrom Mar 2, 2026
Merged
Conversation
Collaborator
Author
|
These are still being tested (through a temporary hijack of the semver-checks), but early feedback is appreciated. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4844 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 208 208
Lines 8166 8166
=======================================
Hits 7725 7725
Misses 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Note: The integration tests failure seems to be because an |
a674821 to
f89c445
Compare
Collaborator
Author
|
This was all tested with: |
coryan
reviewed
Feb 28, 2026
Collaborator
coryan
left a comment
There was a problem hiding this comment.
LGTM, one possible improvement for the future.
f89c445 to
94b2f89
Compare
Collaborator
Author
|
The failures are now because of googleapis/librarian#4276 |
Generates QuickStart samples per service client and per package. Additionally, removes the `veneer` property from librarian.yaml squash
a8aeb33 to
4561060
Compare
Collaborator
Author
|
This is now ready for review, and includes removing |
coryan
approved these changes
Mar 2, 2026
| /// use google_cloud_gax::paginator::ItemPaginator as _; | ||
| /// # async fn sample() -> Result<(), Box<dyn std::error::Error>> { | ||
| /// let client = SchemaService::builder().build().await?; | ||
| /// let parent = "parent_value"; |
Collaborator
There was a problem hiding this comment.
I know these are going to get better pretty soon, but maybe we should have used:
Suggested change
| /// let parent = "parent_value"; | |
| /// let parent = " -- read the service docs for the format of this field --"; |
Collaborator
Author
There was a problem hiding this comment.
Yes, I'll do this as well, even when we get resource names formatted, it's possible that for some we won't be able to identify the format and something like this as a fallback should be better.
coryan
added a commit
that referenced
this pull request
Mar 3, 2026
Reverts #4844 We can roll forward once we figure out the problem with some quickstarts not compiling because the client is not enabled in the default features of the library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.