fix(pubsub)!: return PublishError from Publish instead of an Arc<gax::error>#4681
Merged
suzmue merged 2 commits intogoogleapis:mainfrom Feb 13, 2026
Merged
fix(pubsub)!: return PublishError from Publish instead of an Arc<gax::error>#4681suzmue merged 2 commits intogoogleapis:mainfrom
suzmue merged 2 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4681 +/- ##
==========================================
- Coverage 95.02% 95.01% -0.01%
==========================================
Files 196 196
Lines 7551 7547 -4
==========================================
- Hits 7175 7171 -4
Misses 376 376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suzmue
approved these changes
Feb 13, 2026
Collaborator
suzmue
left a comment
There was a problem hiding this comment.
PR Title nit: reword to finish the sentence "This change modifies the crate to ...". For example "return a PublishError from publish instead of a Arcgax::error"
PR description nit: no colon needed after "For"
| source, | ||
| Some(crate::error::PublishError::OrderingKeyPaused(())) | ||
| ), | ||
| matches!(got_err, crate::error::PublishError::OrderingKeyPaused(())), |
Collaborator
There was a problem hiding this comment.
In a possible future PR, is it possible to clean these up so that we don't have to have a unit type value at all?
coryan
pushed a commit
to coryan/google-cloud-rust
that referenced
this pull request
Feb 18, 2026
…ublish (googleapis#4681) Switch Publisher Publish to return PublishError instead of Arc. For SendError, the application can inspect the source of the send error. The source is wrapped in Arc as an error in a Batch send can cause multiple Publish errors. The tests are also updated to check for the new error type. For googleapis#4650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch Publisher Publish to return PublishError instead of Arc.
For SendError, the application can inspect the source of the send error. The source is wrapped in Arc as an error in a Batch send can cause multiple Publish errors.
The tests are also updated to check for the new error type.
For #4650