feat(pubsub): retries starting subscribe stream#4377
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Jan 24, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4377 +/- ##
==========================================
+ Coverage 94.92% 94.94% +0.01%
==========================================
Files 191 191
Lines 7234 7258 +24
==========================================
+ Hits 6867 6891 +24
Misses 367 367 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Jan 24, 2026
Collaborator
coryan
left a comment
There was a problem hiding this comment.
A few test nits. If this is blocking something, feel free to fix in a follow up PR.
Comment on lines
+162
to
+168
| mockall::mock! { | ||
| #[derive(Debug)] | ||
| BackoffPolicy {} | ||
| impl BackoffPolicy for BackoffPolicy { | ||
| fn on_failure(&self, state: &RetryState) -> Duration; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
nit: we have like 5 of these by now. Time to refactor to google-cloud-test-utils ? Hmmm... Dependencies may be more complicated than we want.
Member
Author
There was a problem hiding this comment.
Time to refactor to google-cloud-test-utils ?
Probably.
dbolduc
added a commit
that referenced
this pull request
Jan 27, 2026
I forgot to remove this in #4377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the work for #4097
Retry attempts to start a stream using default policies.
I do not have plans to let applications set custom policies, but if we need to, we can add support for custom policies later.