test: generate diff - do not merge by zhumin8 · Pull Request #4121 · googleapis/google-cloud-rust

zhumin8 · 2025-12-23T14:53:54Z

This is a test PR to show differences in librarian generate --all from sidekick refresh-all.
For more context googleapis/librarian#3330

zhumin8 · 2025-12-23T15:08:18Z

src/pubsub/src/generated/gapic/client.rs

+/// The service that an application uses to manipulate topics, and to send
+/// messages to a topic.


Found exact source in googleapis: https://github.com/googleapis/googleapis/blob/ef6a532bfd9ab7a944bdedd64c69a2b4042db58b/google/pubsub/v1/pubsub.proto#L45-L46

Seems that the current content in google-cloud-rust is off?

Sometimes we intervene in the comments:

google-cloud-rust/src/pubsub/src/generated/gapic/.sidekick.toml

Line 52 in cde7484

[[documentation-overrides]]

these override are not included in migrated librarian.yaml:

google-cloud-rust/src/pubsub/src/generated/gapic/.sidekick.toml

Lines 50 to 60 in cde7484

# Documentation overrides specific to the Rust clients.

# Dataplane operations are excluded from the TopicAdmin and SubscriptionAdmin clients.

[[documentation-overrides]]

id = ".google.pubsub.v1.Publisher"

match = "The service that an application uses to manipulate topics, and to send\nmessages to a topic."

replace = "The service that an application uses to manipulate topics."

[[documentation-overrides]]

id = ".google.pubsub.v1.Subscriber"

match = "The service that an application uses to manipulate subscriptions and to\nconsume messages from a subscription via the `Pull` method or by\nestablishing a bi-directional stream using the `StreamingPull` method."

replace = "The service that an application uses to manipulate subscriptions."

zhumin8 · 2025-12-23T15:08:20Z

src/pubsub/src/generated/gapic/client.rs

+/// The service that an application uses to manipulate subscriptions and to
+/// consume messages from a subscription via the `Pull` method or by
+/// establishing a bi-directional stream using the `StreamingPull` method.


https://github.com/googleapis/googleapis/blob/ef6a532bfd9ab7a944bdedd64c69a2b4042db58b/google/pubsub/v1/pubsub.proto#L1138-L1140

zhumin8 · 2025-12-23T15:17:17Z

src/generated/cloud/orgpolicy/v1/src/model.rs

+    ///
+    /// ```norust
+    /// - "projects/<project-id>", e.g. "projects/tokyo-rain-123"
+    /// - "folders/<folder-id>", e.g. "folders/1234"
+    /// - "organizations/<organization-id>", e.g. "organizations/1234"
+    /// ```
    ///
    /// The `supports_under` field of the associated `Constraint`  defines whether
+    ///


@ldetmer do you think this in anyway related to googleapis/librarian#3284?

This file looks like a leftover from #198. Other placeholder files created in the same PR were removed, e.g. src/generated/type/src/main.rs, src/generated/cloud/secretmanager/v1/src/main.rs. Encountered this file when comparing generate results, see #4121.

dbolduc · 2025-12-23T16:45:50Z

Aside: is it possible to work out of a fork, instead of branching in the googleapis/google-cloud-rust repo?

We try not to pollute the branches in the main repository.

And I am not sure we have the right branch protections in place.

librarian generate --all diff

1fb144c

zhumin8 mentioned this pull request Dec 23, 2025

chore: remove placeholder file from longrunning #4122

Merged

zhumin8 commented Dec 23, 2025

View reviewed changes

zhumin8 mentioned this pull request Dec 23, 2025

devtools/cmd/migrate-sidekick: diff in generate --all in orgpolicy, longrunning and pubsub googleapis/librarian#3330

Closed

zhumin8 commented Dec 23, 2025

View reviewed changes

julieqiu closed this Jan 2, 2026

julieqiu reopened this Jan 2, 2026

zhumin8 deleted the branch test-prep January 5, 2026 15:30

zhumin8 closed this Jan 5, 2026

zhumin8 deleted the test-diff branch January 5, 2026 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: generate diff - do not merge#4121

test: generate diff - do not merge#4121
zhumin8 wants to merge 1 commit intotest-prepfrom
test-diff

zhumin8 commented Dec 23, 2025

Uh oh!

zhumin8 Dec 23, 2025

Uh oh!

dbolduc Dec 23, 2025

Uh oh!

zhumin8 Dec 23, 2025

Uh oh!

zhumin8 Dec 23, 2025

Uh oh!

zhumin8 Dec 23, 2025

Uh oh!

dbolduc commented Dec 23, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		/// The service that an application uses to manipulate topics, and to send
		/// messages to a topic.

	# Documentation overrides specific to the Rust clients.
	# Dataplane operations are excluded from the TopicAdmin and SubscriptionAdmin clients.
	[[documentation-overrides]]
	id = ".google.pubsub.v1.Publisher"
	match = "The service that an application uses to manipulate topics, and to send\nmessages to a topic."
	replace = "The service that an application uses to manipulate topics."

	[[documentation-overrides]]
	id = ".google.pubsub.v1.Subscriber"
	match = "The service that an application uses to manipulate subscriptions and to\nconsume messages from a subscription via the `Pull` method or by\nestablishing a bi-directional stream using the `StreamingPull` method."
	replace = "The service that an application uses to manipulate subscriptions."

Conversation

zhumin8 commented Dec 23, 2025

Uh oh!

zhumin8 Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

dbolduc Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

zhumin8 Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

zhumin8 Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

zhumin8 Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

dbolduc commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dbolduc commented Dec 23, 2025 •

edited

Loading