fix(gaxi): retry connect errors#3656
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Oct 31, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
==========================================
- Coverage 95.90% 95.83% -0.07%
==========================================
Files 128 128
Lines 5152 5162 +10
==========================================
+ Hits 4941 4947 +6
- Misses 211 215 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the work for #3640
This PR effectively starts retrying connect errors, for non-idempotent operations, by default, in GAPICs.
Note that we marked connect errors as
is_transient_and_before_rpcin #3654. Thus, connect errors would be retried by the default retry policy(Aip194Strict)...... if they existed. But we did not ever classify an error as connect. This PR starts classifying the HTTP connect errors as such.