Skip to content

DNS and connection errors should be retryable #3640

@coryan

Description

@coryan

Once I got a DNS error (I am running this from home, on my laptop):

---- parallel stdout ----
Error: the transport reports an error: error sending request for url (https://storage.googleapis.com/upload/storage/v1/b/coryan-test-bucket/o?uploadType=multipart&name=dc0d9e8b-b534-487a-b285-5f40ca473bcd%2Fobject-000)

Caused by:
    0: error sending request for url (https://storage.googleapis.com/upload/storage/v1/b/coryan-test-bucket/o?uploadType=multipart&name=dc0d9e8b-b534-487a-b285-5f40ca473bcd%2Fobject-000)
    1: client error (Connect)
    2: dns error
    3: failed to lookup address information: nodename nor servname provided, or not known

The retry loop can handle such errors, but requires idempotent requests, and therefore request preconditions.

I am wrong in that last bit. The DNS + connection errors are always retryable, even if the operation is not idempotent. No request data never left the local computer.

This affects both the Aip194Strict policy and the default policy for storage.

Originally posted by @coryan in #3574

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the Cloud Storage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions