feat(spanner): add batch_create_session calls to session pools#9488
Merged
larkee merged 7 commits intogoogleapis:masterfrom Oct 23, 2019
larkee:batch-create-sessions-manual
Merged
feat(spanner): add batch_create_session calls to session pools#9488larkee merged 7 commits intogoogleapis:masterfrom larkee:batch-create-sessions-manual
larkee merged 7 commits intogoogleapis:masterfrom
larkee:batch-create-sessions-manual
Conversation
Contributor
Author
|
Build failure is due to a known flaky test. |
Contributor
tseaver
approved these changes
Oct 22, 2019
crwilcox
approved these changes
Oct 22, 2019
Contributor
|
Failure seems to be in an unrelated area. |
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Update session pools to use batch_create_sessions * Update session pool unit tests to handle batch_create_session calls * Fix where PingingPool sessions are added to in batch_create_session * Remove unnecessary variable from FixedSizePool bind() * Remove unused import * Apply lint formatting to test_pool.py * Update 'batch_create_sessions' to remove session_count keyword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, session pools are filled by creating single sessions. For large session pool sizes (>1000) this can be incredibly slow as it requires >1000 requests to be made to the server sequentially. Using batch_create_session calls to fill the pools will reduce the number of requests by a factor of 100 which will greatly reduce the start up time.
The BurstyPool does not use batch_create_session as it is designed to create sessions on an "as needed" basis rather than filling a queue.