Skip to content

Bigtable: fix rendering of instance admin snippets.#7797

Merged
tseaver merged 3 commits intogoogleapis:masterfrom
sangramql:bigtable_snippets_remove_duplicates
May 1, 2019
Merged

Bigtable: fix rendering of instance admin snippets.#7797
tseaver merged 3 commits intogoogleapis:masterfrom
sangramql:bigtable_snippets_remove_duplicates

Conversation

@sangramql
Copy link
Copy Markdown
Contributor

@sangramql sangramql commented Apr 24, 2019

Closes #7522.

@sangramql sangramql requested a review from crwilcox as a code owner April 24, 2019 15:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@sangramql
Copy link
Copy Markdown
Contributor Author

@crwilcox @AVaksman @sduskis
Please review the code.

@tseaver tseaver changed the title Fix snippets for issue 7522 Bigtable: harden instance admin snippets. Apr 29, 2019
@tseaver tseaver added api: bigtable Issues related to the Bigtable API. kokoro:force-run Add this label to force Kokoro to re-run the tests. testing labels Apr 29, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2019
@tseaver tseaver changed the title Bigtable: harden instance admin snippets. Bigtable: fix rendering of instance admin snippets. Apr 29, 2019
@sangramql sangramql requested a review from tseaver as a code owner April 30, 2019 09:04
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2019
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Apr 30, 2019

@sangramql I can't see the failed Kokoro log, but @busunkim96 reports that it is:

Running session lint
Creating virtualenv using python3.7 in /tmpfs/src/github/google-cloud-python/bigtable/.nox/lint
pip install flake8 black ../api_core ../core
black --check google tests docs
 would reformat /tmpfs/src/github/google-cloud-python/bigtable/docs/snippets.py
All done! 💥 💔 💥
1 file would be reformatted, 72 files would be left unchanged.
Command black --check google tests docs failed with exit code 1 Session lint failed.

Can you please run nox -re blacken, commit, and push?

@sangramql
Copy link
Copy Markdown
Contributor Author

nox -re blacken is working fine on my machine.
I also added 3.7 check.
@nox.session(python=["3.6","3.7"])
def blacken(session):
"""Run black.

--------------cmd--------------
MacBook-Pro:bigtable sqa$ nox -re blacken
nox > Running session blacken-3.6
nox > Re-using existing virtualenv at /Users/sqa/Documents/GitHub/google-cloud-python/bigtable/.nox/blacken-3-6.
nox > pip install --upgrade black
nox > black google tests docs
All done! ✨ 🍰 ✨
73 files left unchanged.
nox > Session blacken-3.6 was successful.
nox > Running session blacken-3.7
nox > Re-using existing virtualenv at /Users/sqa/Documents/GitHub/google-cloud-python/bigtable/.nox/blacken-3-7.
nox > pip install --upgrade black
nox > black google tests docs
All done! ✨ 🍰 ✨
73 files left unchanged.
nox > Session blacken-3.7 was successful.
nox > Ran multiple sessions:
nox > * blacken-3.6: success
nox > * blacken-3.7: success

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 1, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2019
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented May 1, 2019

Ignoring spurious pubsub / logging / storage failures.

@tseaver tseaver merged commit 8a0486e into googleapis:master May 1, 2019
parthea pushed a commit that referenced this pull request Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bigtable: docs Snippet only includes half of documentation

5 participants