remove gRPC size limit for bigquery storage#7664
Conversation
MartinNowak
commented
Apr 5, 2019
- currently limited to 4MiB
- compare to f636c8d which does the same for the monitoring API
- currently limited to 4MiB - compare to googleapis@f636c8d which does the same for the monitoring API
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@crwilcox Could you review this? Seems okay once @MartinNowak signs the CLA, but I don't know if synthtool is just going to overwrite it. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
tswast
left a comment
There was a problem hiding this comment.
Thanks for the contribution @MartinNowak. FYI: I've added this to synth.py as well so that the code generator doesn't override your changes.
* remove gRPC size limit for bigquery storage - currently limited to 4MiB - compare to f636c8d which does the same for the monitoring API * Add override to synth config.
* remove gRPC size limit for bigquery storage - currently limited to 4MiB - compare to f636c8d which does the same for the monitoring API * Add override to synth config.