Skip to content

Way to change the mutation timeout in bigtable.#7424

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
juan-rael:mutation_timeout
Feb 27, 2019
Merged

Way to change the mutation timeout in bigtable.#7424
tseaver merged 1 commit intogoogleapis:masterfrom
juan-rael:mutation_timeout

Conversation

@juan-rael
Copy link
Copy Markdown
Contributor

@juan-rael juan-rael commented Feb 22, 2019

In some cases, we need to set a greater timeout to wait for a request, right now it isn't a way to change this value.

setting the timeout in the mutation batcher we can set this time or set it in blank to take the default value.

def test_mutate_rows_timeout(self):
        table = _Table(self.TABLE_NAME)
        mutation_batcher = MutationsBatcher(table=table, timeout=600000)

        row = DirectRow(row_key=b"row_key")
        row.set_cell("cf1", b"c1", 1)
        row.set_cell("cf1", b"c2", 2)
        row.set_cell("cf1", b"c3", 3)
        row.set_cell("cf1", b"c4", 4)

        mutation_batcher.mutate(row)

        mutation_batcher.flush()

        self.assertEqual(table.mutation_calls, 1)

@juan-rael juan-rael requested a review from crwilcox as a code owner February 22, 2019 13:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2019
tseaver
tseaver suggested changes Feb 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! I think we can simplify it a bit.

@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Feb 22, 2019
@juan-rael
Copy link
Copy Markdown
Contributor Author

juan-rael commented Feb 26, 2019

I do all the changes. @tseaver

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2019
tseaver
tseaver suggested changes Feb 26, 2019
View reviewed changes
@juan-rael
Copy link
Copy Markdown
Contributor Author

juan-rael commented Feb 27, 2019

resolved it

@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Feb 27, 2019

@juan-rael Thanks for working through my review. In future PRs, please don't rebase / squash when replying to review comments: keeping the commits separate makes it easier to verify that the requested change was made. We end up squash-merging the whole thing at the end, anyway.

@tseaver tseaver merged commit 35e0349 into googleapis:master Feb 27, 2019
parthea pushed a commit that referenced this pull request Nov 22, 2025
@juan-rael @tseaver
Add 'Table.mutation_timeout', allowing override of config timeouts. (#…
c033a96 
…7424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juan-rael @tseaver @googlebot @yoshi-kokoro