Skip to content

Bigtable: improve 'Policy' interchange w/ JSON, gRPC payloads.#7378

Merged
tseaver merged 3 commits intogoogleapis:masterfrom
tseaver:7369-bigtable-policy_etag_json
Feb 20, 2019
Merged

Bigtable: improve 'Policy' interchange w/ JSON, gRPC payloads.#7378
tseaver merged 3 commits intogoogleapis:masterfrom
tseaver:7369-bigtable-policy_etag_json

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Feb 18, 2019

Closes #7369.

Use them for interchange with the 'google.iam.v1.policy_pb2.Policy'
messages.
Convert 'etag' attr to / from bytes to maintain JSON compatibility.

Closes #7369.
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Feb 18, 2019
@tseaver tseaver requested a review from crwilcox as a code owner February 18, 2019 19:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2019
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Feb 19, 2019

@crwilcox Unrelated Kokoro failures (these jobs shouldn't even be run, karthago delenda est):

  • pubsub, "Failed to clone GitHub repository"
  • language, "Failed to clone GitHub repository"
  • securitycenter, "Failed to clone GitHub repository"
  • vision: non-public Kokoro URL.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@tseaver tseaver merged commit 563d083 into googleapis:master Feb 20, 2019
@tseaver tseaver deleted the 7369-bigtable-policy_etag_json branch February 20, 2019 18:22
parthea pushed a commit that referenced this pull request Nov 22, 2025
Add 'Policy.from_pb' factory and 'Policy.to_pb' method. Use them
for interchange with the 'google.iam.v1.policy_pb2.Policy' messages.

Override 'Policy.{from_api_repr,to_api_repr}', converting 'etag' attr
to / from bytes to maintain JSON compatibility.

Closes #7369.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants