Skip to content

Bigtable Row Set snippets#7016

Merged
crwilcox merged 12 commits intogoogleapis:masterfrom
sangramql:bigtable_addrow_snippets
Mar 8, 2019
Merged

Bigtable Row Set snippets#7016
crwilcox merged 12 commits intogoogleapis:masterfrom
sangramql:bigtable_addrow_snippets

Conversation

@sangramql
Copy link
Copy Markdown
Contributor

No description provided.

@sangramql sangramql requested a review from crwilcox as a code owner December 22, 2018 22:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2018
@sangramql
Copy link
Copy Markdown
Contributor Author

@tseaver @sduskis @AVaksman
Please review the updated PR.

@tseaver tseaver added api: bigtable Issues related to the Bigtable API. type: docs Improvement to the documentation for an API. labels Jan 3, 2019
@sangramql
Copy link
Copy Markdown
Contributor Author

@tseaver @sduskis This is updated PR and ready to merge i suppose.

@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Feb 7, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019
Config.TABLE.mutate_rows(rows)

# [START bigtable_add_row_key]
from google.cloud.bigtable import Client
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the Client related code here. The RowSet code is enough.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the format we use for the api docs samples for python, so I think it is fine to leave this in.

assert found_row_keys == expected_row_keys

# [START bigtable_add_row_range]
from google.cloud.bigtable import Client
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

assert found_row_keys == expected_row_keys

# [START bigtable_row_range_from_keys]
from google.cloud.bigtable import Client
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here.

@billyjacobson
Copy link
Copy Markdown
Contributor

Looks good to me

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@crwilcox crwilcox merged commit 337f748 into googleapis:master Mar 8, 2019
parthea pushed a commit that referenced this pull request Nov 22, 2025
* add conditional row snippets

* add snippets

* Add row set snippets

* remove unwanted changes in snippets.py

* Rectify snippets file name and tags

* blacken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants