Skip to content

Fix formatting#7002

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
zenbanffy:patch-1
Jan 3, 2019
Merged

Fix formatting#7002
tseaver merged 1 commit intogoogleapis:masterfrom
zenbanffy:patch-1

Conversation

@zenbanffy
Copy link
Copy Markdown
Contributor

Small fix to formatting - a line that ended up formatted as code that shouldn't

Small fix to formatting - a line that ended up formatted as code that shouldn't
@zenbanffy zenbanffy requested a review from crwilcox as a code owner December 19, 2018 11:32
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 19, 2018
@zenbanffy
Copy link
Copy Markdown
Contributor Author

How do I sign a CLA?

@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Dec 19, 2018

@zenbanffy

How do I sign a CLA?

The bot linked the page:

Please visit https://cla.developers.google.com/ to sign.

@tseaver tseaver added api: clouderrorreporting Issues related to the Error Reporting API. type: docs Improvement to the documentation for an API. labels Dec 19, 2018
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Dec 19, 2018

@crwilcox, @theacodes This is truly a "no copyright possible" change.

@zenbanffy
Copy link
Copy Markdown
Contributor Author

I'm asking my manager if I can sign the corporate agreement, but I agree a copyright case would be very easy to shot down. It's my second smallest PR ever.

Are you the Tres Seaver I know from Zope?

@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Dec 19, 2018

@zenbanffy

Are you the Tres Seaver I know from Zope?

Yup.

@crwilcox
Copy link
Copy Markdown
Contributor

Thanks for finding this @zenbanffy. Unfortunately it is safer that all incoming PRs require a CLA, even if it is a space in a doc. :( That said, if you don't expect to ever contribute again, I can make this documentation modification as myself so you don't have to sign a CLA for a deletion of a space.

So, let me know how you would like to proceed. If you think you will want to contribute again to this or another google open source product it may be worth getting it out of the way now so next time it is faster.

@zenbanffy
Copy link
Copy Markdown
Contributor Author

I'm pretty sure we'll need to fix the CLA thing eventually. I should have a definitive answer soon enough - I'll not be the first Zendeskian to go through this.

@zenbanffy
Copy link
Copy Markdown
Contributor Author

I was added to the CLA group. Do I need to do anything else?

@crwilcox
Copy link
Copy Markdown
Contributor

@zenbanffy If you reply with 'I signed it!' to this thread it ought to rescan.

@crwilcox
Copy link
Copy Markdown
Contributor

@zenbanffy just checking in. If you can reply to this with "I signed it!" the bot should check the agreement and clear the CLA check.

@zenbanffy
Copy link
Copy Markdown
Contributor Author

zenbanffy commented Jan 1, 2019 via email

@crwilcox crwilcox removed the cla: no This human has *not* signed the Contributor License Agreement. label Jan 3, 2019
@tseaver tseaver merged commit ebe21de into googleapis:master Jan 3, 2019
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: clouderrorreporting Issues related to the Error Reporting API. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants