Bigtable: TimestampRanges must be milliseconds granularity #5002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not familiar with how Bigtable handles timestamps. @mbrukman might? |
Contributor
Author
|
oh. Here's some related info also bigtable support for microseconds |
Contributor
|
I'm going to make the executive decision. This is for row range filters. For now, start out to be rounded down to nearest ms, and end needs to be rounded up to the nearest ms. If and when Cloud Bigtable opts to enable microsecond support, which is not on the near term roadmap, we'll have to do a sweep of all clients for behavior like this. |
tswast
reviewed
Mar 15, 2018
| if self.end is not None: | ||
| timestamp_range_kwargs['end_timestamp_micros'] = ( | ||
| _microseconds_from_datetime(self.end)) | ||
| _microseconds_from_datetime(self.end) // 1000 * 1000) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
reviewed
Mar 15, 2018
| end = None | ||
| if end_micros is not None: | ||
| end = _EPOCH + datetime.timedelta(microseconds=end_micros) | ||
| pb_kwargs['end_timestamp_micros'] = end_micros |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
8e31bd5 to
508e40f
Compare
508e40f to
edd9ce1
Compare
edd9ce1 to
abf1d79
Compare
Contributor
Author
|
@tswast yeah, stupid mistake. I changed the tests to better capture what it should do. |
tswast
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4932.
But. @tswast Should we have this and change it if/when BigTable supports microseconds or should we have the users handle it themselves and just document?