Skip to content

Move dns code into a subpackage#2428

Merged
dhermes merged 2 commits intogoogleapis:masterfrom
dhermes:make-dns-subpackage
Sep 26, 2016
Merged

Move dns code into a subpackage#2428
dhermes merged 2 commits intogoogleapis:masterfrom
dhermes:make-dns-subpackage

Conversation

@dhermes
Copy link
Copy Markdown
Contributor

@dhermes dhermes commented Sep 26, 2016

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-dns-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package dns \
  --package-name "Google Cloud DNS" \
  --readme "${READMES_DIR}/dns/README.rst"

Done via:

$ mkdir -p dns/google/cloud
$ cp google/__init__.py dns/google/__init__.py
$ git add dns/google/__init__.py
$ cp google/cloud/__init__.py dns/google/cloud/__init__.py
$ git add dns/google/cloud/__init__.py
$ git mv google/cloud/dns dns/google/cloud/dns
$ git mv unit_tests/dns dns/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-dns as a dependency to the umbrella
  package
- Adding the dns subdirectory into the list of packages
  for verifying the docs
- Incorporating the dns subdirectory into the umbrella
  coverage report
- Adding the dns only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the dns
  tox config
@dhermes dhermes added api: dns Issues related to the Cloud DNS API. packaging labels Sep 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2016
@dhermes dhermes changed the title Move storage code into a subpackage Move dns code into a subpackage Sep 26, 2016
Copy link
Copy Markdown
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small teensy nit

Quick Start
-----------

::

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes merged commit 796f745 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-dns-subpackage branch September 26, 2016 21:19
parthea pushed a commit that referenced this pull request Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
<details><summary>bigframes: 2.34.0</summary>

##
[2.34.0](googleapis/python-bigquery-dataframes@v2.33.0...v2.34.0)
(2026-02-02)


### Features

* add `bigframes.pandas.options.experiments.sql_compiler` for switching
the backend compiler (#2417)
([7eba6ee03f07938315d99e2aeaf72368c02074cf](googleapis/python-bigquery-dataframes@7eba6ee))
* add bigquery.ml.generate_embedding function (#2422)
([35f3f5e6f8c64b47e6e7214034f96f047785e647](googleapis/python-bigquery-dataframes@35f3f5e))
* add bigquery.create_external_table method (#2415)
([76db2956e505aec4f1055118ac7ca523facc10ff](googleapis/python-bigquery-dataframes@76db295))
* add deprecation warnings for .blob accessor and read_gbq_object_table
(#2408)
([7261a4ea5cdab6b30f5bc333501648c60e70be59](googleapis/python-bigquery-dataframes@7261a4e))
* add bigquery.ml.generate_text function (#2403)
([5ac681028624de15e31f0c2ae360b47b2dcf1e8d](googleapis/python-bigquery-dataframes@5ac6810))


### Bug Fixes

* broken job url (#2411)
([fcb5bc1761c656e1aec61dbcf96a36d436833b7a](googleapis/python-bigquery-dataframes@fcb5bc1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants