Refactor datastore connection: move behavior into API objects#2287
Closed
dhermes wants to merge 9 commits intogoogleapis:masterfrom
Closed
Refactor datastore connection: move behavior into API objects#2287dhermes wants to merge 9 commits intogoogleapis:masterfrom
dhermes wants to merge 9 commits intogoogleapis:masterfrom
Conversation
| return self._stub.AllocateIds(request_pb) | ||
|
|
||
|
|
||
| def build_api_url(project, method, base_url): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
I could be missing something, but there is logic in the non-virtual "public" methods which needs testing. Did we just not have explicit tests for those connection methods before? |
Contributor
|
LGTM. Maybe we need an issue to track adding explicit coverage for the API methods (whichever way we go about dropping |
Contributor
Author
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
#2287) This pull request addresses a pagination display bug in the `anywidget` table where a small DataFrame (e.g., 5 rows) would incorrectly show "Page 1 of 5" instead of "Page 1 of 1". * **Fixed `table_widget.js` pagination logic:** Corrected the JavaScript to accurately calculate total pages, ensuring "Page 1 of 1" is displayed for datasets smaller than the page size. * **Added comprehensive system test:** Enhanced `test_anywidget.py` by improving the `test_widget_with_few_rows_should_have_only_one_page` test. This test now explicitly asserts the correct `row_count` and verifies that page navigation is correctly clamped to the first page, thus confirming the backend conditions for the "Page 1 of 1" frontend display. Fixes #<issue_number_goes_here> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tseaver This is what we discussed in #2230. LMKWYT. This way we can just ditch
google.cloud.client.Client(for_ClientFactoryMixin) and remove theconnectionmodule. Right now, the only real logic in theConnectionclass is in the constructor.