Tolerate timestamps w/ truncated nanos.#1785
Tolerate timestamps w/ truncated nanos.#1785tseaver merged 2 commits intogoogleapis:masterfrom tseaver:1783-timestamp_nanos_truncated
Conversation
| with self.assertRaises(ValueError): | ||
| self._callFUT(dt_str) | ||
| truncateds_and_micros = [ | ||
| ('12345678', 123456), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I don't have the bandwidth right now to follow this properly, but have you guys looked at the proto3 JSON mapping spec for Timestamp and the |
|
Possibly, the phrase
may actually shed some light on what we've seen empirically. |
|
@dhermes Seems like you didn't find a counter-example to the "truncate/floor to micros" bit. |
|
Yeah LGTM |
…tamp_params.py` (#1785) * Updates file * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Correcting RowIterator * Correcting variable names --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Swast <swast@google.com>
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos. BEGIN_COMMIT BEGIN_NESTED_COMMIT feat: Added a new field `ComposeObjectRequest.delete_source_objects` field PiperOrigin-RevId: 863087065 Library-IDs: google-cloud-storage Source-link: [googleapis/googleapis@51ff87f4](googleapis/googleapis@51ff87f4) END_NESTED_COMMIT BEGIN_NESTED_COMMIT docs: Updated documentation for `BidiReadObject`, `ReadObjectRequest`, and `ObjectContexts` PiperOrigin-RevId: 863087065 Library-IDs: google-cloud-storage Source-link: [googleapis/googleapis@51ff87f4](googleapis/googleapis@51ff87f4) END_NESTED_COMMIT END_COMMIT This pull request is generated with proto changes between [googleapis/googleapis@5400ccce](googleapis/googleapis@5400ccc) (exclusive) and [googleapis/googleapis@51ff87f4](googleapis/googleapis@51ff87f) (inclusive). Librarian Version: v1.0.2-0.20260309131826-42ac5c451239 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91
… inconsistency with pandas (#1785) * fix: read_csv with both index_col and use_cols inconsistent with pandas * ensure columns is not list type and avoid flacky ordered of columns * add docstring for index_col_in_columns and fix tests --------- Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Closes #1783.