fix(bigframes): Fix IsInOp literal bug with sqlglot#17356
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces sge.convert with sql.literal when compiling comparison operations, and adds unit tests and snapshots to verify the handling of various float literals (such as infinity, NaN, and scientific notation). The review feedback correctly points out that using sql.literal will likely raise a NameError because the sql module is not imported, and suggests using sge.literal instead for consistency and safety.
sycai
pushed a commit
that referenced
this pull request
Jun 9, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.16.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e <details><summary>bigframes: v2.42.0</summary> ## [v2.42.0](bigframes-v2.41.0...bigframes-v2.42.0) (2026-06-08) ### Features * Add ai_generate functions to the dataframe bq accessor (#17302) ([6b62cb6](6b62cb6f)) * support automatic per-cell execution history filtering and isolated callbacks (#17144) ([7d44011](7d440111)) * create `Series.bigquery.function_name` accessors for array and AEAD functions (#17279) ([d01a4ba](d01a4ba3)) ### Bug Fixes * include pyopenssl as a dependency (#17362) ([1f6205e](1f6205ee)) * Fix IsInOp literal bug with sqlglot (#17356) ([a3d93af](a3d93afe)) * nameless column to_frame bug for pandas 3.0 (#17371) ([b23bfa4](b23bfa4c)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕