Closed
Conversation
vchudnov-g
pushed a commit
that referenced
this pull request
Mar 14, 2025
This PR fixes an issue in `googleapis-common-protos` where `excludes` is set in `tool.setuptools.packages.find`, without specifying `include` which may cause strange installation behaviour as seen in this [build log](https://github.com/googleapis/google-cloud-python/actions/runs/13822574147/job/38671145919) from PR #13657. https://github.com/googleapis/google-cloud-python/blob/a2466af25d832eab04153e8bde446a9e9e523d2b/packages/googleapis-common-protos/pyproject.toml#L53-L54 See the following from the log ``` 2025-03-13T02:08:01.5380028Z copying google/type/timeofday.proto -> build/lib/google/type 2025-03-13T02:08:01.5380508Z copying google/type/timeofday_pb2.pyi -> build/lib/google/type 2025-03-13T02:08:01.5381044Z copying google/longrunning/operations_proto.proto -> build/lib/google/longrunning 2025-03-13T02:08:01.5381779Z copying google/longrunning/operations_proto_pb2.pyi -> build/lib/google/longrunning 2025-03-13T02:08:01.5382515Z copying google/cloud/extended_operations.proto -> build/lib/google/cloud 2025-03-13T02:08:01.5383066Z copying google/cloud/extended_operations_pb2.pyi -> build/lib/google/cloud 2025-03-13T02:08:01.5383725Z copying google/logging/type/http_request.proto -> build/lib/google/logging/type 2025-03-13T02:08:01.5384343Z copying google/logging/type/http_request_pb2.pyi -> build/lib/google/logging/type 2025-03-13T02:08:01.5384894Z copying google/logging/type/log_severity.proto -> build/lib/google/logging/type 2025-03-13T02:08:01.5385554Z copying google/logging/type/log_severity_pb2.pyi -> build/lib/google/logging/type 2025-03-13T02:08:01.5386189Z copying google/gapic/metadata/gapic_metadata.proto -> build/lib/google/gapic/metadata 2025-03-13T02:08:01.5386932Z copying google/gapic/metadata/gapic_metadata_pb2.pyi -> build/lib/google/gapic/metadata 2025-03-13T02:08:01.5387616Z copying google/rpc/context/attribute_context.proto -> build/lib/google/rpc/context 2025-03-13T02:08:01.5388236Z copying google/rpc/context/attribute_context_pb2.pyi -> build/lib/google/rpc/context 2025-03-13T02:08:01.5388920Z copying google/rpc/context/audit_context.proto -> build/lib/google/rpc/context 2025-03-13T02:08:01.5389497Z copying google/rpc/context/audit_context_pb2.pyi -> build/lib/google/rpc/context 2025-03-13T02:08:01.5390104Z copying google/cloud/location/locations.proto -> build/lib/google/cloud/location 2025-03-13T02:08:01.5390777Z copying google/cloud/location/locations_pb2.pyi -> build/lib/google/cloud/location 2025-03-13T02:08:01.5413887Z copying build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib....../lib/google/api ``` I've confirmed that setting `include = ["google*"]` for `tool.setuptools.packages.find` fixes the issue. See build log [here](https://github.com/googleapis/google-cloud-python/actions/runs/13862478909/job/38794042745) from PR #13657. We also do this in other packages: https://github.com/googleapis/google-cloud-python/blob/a2466af25d832eab04153e8bde446a9e9e523d2b/packages/grpc-google-iam-v1/pyproject.toml#L52-L53 See https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration for more information on `tool.setuptools.packages.find`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For testing purposes