-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Removal of .proto files from googleapis-common-protos broke us #13545
Copy link
Copy link
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Determine this is the right repository
- I determined this is the correct repository in which to report this bug.
Summary of the issue
Context
23e0f96 removed the source .proto files for Google APIs. Since we use these protos in our project to build our own services with gRPC, this broke our build process.
Expected Behavior:
I would have expected the .proto files to have stayed in place or another pip package to be provided that published the source proto files for existing users.
Actual Behavior:
.proto files removed, build broken
API client name and version
No response
Reproduction steps: code
file: main.py
def reproduce():
# complete code hereReproduction steps: supporting files
file: mydata.csv
alpha,1,3
beta,2,5
Reproduction steps: actual results
file: output.txtmydata.csv
Calculated: foo
Reproduction steps: expected results
file: output.txtmydata.csv
Calculated: bar
OS & version + platform
No response
Python environment
No response
Python dependencies
No response
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.