Skip to content

[BC Break] Add timestamp/insertId support to Logger::entry() #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dwsupplee merged 1 commit into from
Apr 24, 2017
Merged

[BC Break] Add timestamp/insertId support to Logger::entry() #462

dwsupplee merged 1 commit into from
Apr 24, 2017

Conversation

@dwsupplee
Copy link
Contributor

@dwsupplee dwsupplee commented Apr 24, 2017 •
edited
Loading

Closes: #453

This PR includes a few items:

  • The Duration/Timestamp classes have been moved out of PubSub and into Core to be shared. This is a breaking change.
  • A fix for an issue with handling sub second precision while using gRPC.
  • Support for insertId.
  • Support for timestamp. The following values are accepted, and if none are provided the client will generate a timestamp at the point the entry is created.
    • A RFC3339 UTC "Zulu" formatted string
    • A \DateTimeInterface implementation
    • A Timestamp instance
    • null, in this case the server will generate the timestamp

@dwsupplee dwsupplee added the api: logging Issues related to the Cloud Logging API. label Apr 24, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2017
@dwsupplee dwsupplee force-pushed the timestamp-insertid branch from a618c81 to f430688 Compare April 24, 2017 03:05
@dwsupplee dwsupplee force-pushed the timestamp-insertid branch from f430688 to c117478 Compare April 24, 2017 03:08
@jdpedrie jdpedrie changed the title Add timestamp/insertId support to Logger::entry() [BC Break] Add timestamp/insertId support to Logger::entry() Apr 24, 2017
@jdpedrie jdpedrie added api: pubsub Issues related to the Pub/Sub API. api: core labels Apr 24, 2017
jdpedrie
jdpedrie approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tmatsuo should take a look too.

@dwsupplee
Copy link
Contributor Author

dwsupplee commented Apr 24, 2017

Yes, please :)

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 24, 2017

LGTM

@dwsupplee dwsupplee merged commit 09be6ba into googleapis:master Apr 24, 2017
tmatsuo pushed a commit that referenced this pull request Apr 24, 2017
Revert "Add timestamp/insertId support to Logger::entry() (#462)"
66069c6 
This reverts commit 09be6ba.
@dwsupplee dwsupplee mentioned this pull request Apr 25, 2017
Merged
@dwsupplee dwsupplee mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jdpedrie jdpedrie jdpedrie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logger Entry should create timestamp when instantiated

4 participants

@dwsupplee @tmatsuo @jdpedrie @googlebot