feat: add keepalive setting in data client#3565
Merged
dwsupplee merged 3 commits intogoogleapis:masterfrom Mar 22, 2021
Merged
Conversation
Contributor
|
Hi @sushanb 👋, Would you be able to share the context which prompted this change? Just hoping to understand a little more before we resort to defaulting to this for all users. Thanks! |
gcf-merge-on-green bot
pushed a commit
to googleapis/nodejs-bigtable
that referenced
this pull request
Jan 27, 2021
- [PHP reference implementation](googleapis/google-cloud-php#3565) This adds two gRPC keepalive options: - `GRPC_ARG_KEEPALIVE_TIME_MS` to 30s - `GRPC_ARG_KEEPALIVE_TIMEOUT_MS` to 10s
dwsupplee
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets KeepAlive timer to 30s (Google Frontends are configured limits keepalive calls at 30s by default. If used below 30s, grpc automatically increases keepalive time by 2x after too_many_ping commands).
Sets KeepAliveTimeout to 10s (conservative)