feat: add google token class in auth#813
Merged
miguelvelezsa merged 14 commits intomainfrom Dec 1, 2025
Merged
Conversation
quirogas
previously approved these changes
Nov 17, 2025
Contributor
|
Seems like there are some linting issues. |
sofisl
previously approved these changes
Nov 26, 2025
Contributor
|
@miguelvelezsa make sure to add the license header on these files! |
quirogas
previously approved these changes
Nov 26, 2025
Contributor
quirogas
left a comment
There was a problem hiding this comment.
LGTM. Only one comment, but it shouldn't be a blocker.
quirogas
approved these changes
Dec 1, 2025
miguelvelezsa
added a commit
that referenced
this pull request
Dec 3, 2025
* feat: add googleToken * chore: create new file for tokenOptions * chore(google-auth-library-nodejs): set types for TokenOptions.additionalClaims * build: add copyright message --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com>
miguelvelezsa
added a commit
that referenced
this pull request
Dec 3, 2025
* feat: add googleToken * chore: create new file for tokenOptions * chore(google-auth-library-nodejs): set types for TokenOptions.additionalClaims * build: add copyright message --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com>
miguelvelezsa
added a commit
that referenced
this pull request
Dec 3, 2025
* feat: add googleToken * chore: create new file for tokenOptions * chore(google-auth-library-nodejs): set types for TokenOptions.additionalClaims * build: add copyright message --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com>
miguelvelezsa
added a commit
that referenced
this pull request
Dec 4, 2025
* feat: add googleToken * chore: create new file for tokenOptions * chore(google-auth-library-nodejs): set types for TokenOptions.additionalClaims * build: add copyright message --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR for #841.
This is just the creation of GoogleToken class. The main class to be migrated from https://github.com/googleapis/node-gtoken/blob/main/esm/src/index.ts#L74. Initial PR just include the skeleton and the interfaces for the options.
Also we wrapped all the options in one variable instead of having all of them as variables for the class.