Merged
Conversation
chore: release main
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…submit workflows (#828) * build: remove wrong field in workflows * build: use dorny/paths-filter in presubmit and continous workflows
Co-authored-by: miguel <miguelvelezsa@google.com>
* fix: upgrade rimraf dependency and move it to dev dependencies * fix: move rimraf to dev dependency
…submit workflows (#828) * build: remove wrong field in workflows * build: use dorny/paths-filter in presubmit and continous workflows
Co-authored-by: miguel <miguelvelezsa@google.com>
sofisl
previously approved these changes
Nov 26, 2025
quirogas
previously approved these changes
Dec 2, 2025
Contributor
quirogas
left a comment
There was a problem hiding this comment.
LGTM. Had two small comments/questions.
packages/google-auth-library-nodejs/src/gtoken/getCredentials.ts
Outdated
Show resolved
Hide resolved
quirogas
approved these changes
Dec 2, 2025
Merged
miguelvelezsa
added a commit
that referenced
this pull request
Dec 3, 2025
* chore(deps): update dependency jsdoc-region-tag to v4 (#831) * build: calculate changes instead of using external action (#834) * chore: fix lint * build: use temp dir in credentials test * build: added error message in case of invalid json --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
miguelvelezsa
added a commit
that referenced
this pull request
Dec 3, 2025
* chore(deps): update dependency jsdoc-region-tag to v4 (#831) * build: calculate changes instead of using external action (#834) * chore: fix lint * build: use temp dir in credentials test * build: added error message in case of invalid json --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
miguelvelezsa
added a commit
that referenced
this pull request
Dec 3, 2025
* chore(deps): update dependency jsdoc-region-tag to v4 (#831) * build: calculate changes instead of using external action (#834) * chore: fix lint * build: use temp dir in credentials test * build: added error message in case of invalid json --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
miguelvelezsa
added a commit
that referenced
this pull request
Dec 4, 2025
* chore(deps): update dependency jsdoc-region-tag to v4 (#831) * build: calculate changes instead of using external action (#834) * chore: fix lint * build: use temp dir in credentials test * build: added error message in case of invalid json --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: feywind <57276408+feywind@users.noreply.github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
build: add gtoken get credentials
END_COMMIT_OVERRIDE
Third PR for #841.
Creation of getCredentials function. We are having the function in separate file instead of a private method in the GoogleToken class https://github.com/googleapis/node-gtoken/blob/main/esm/src/index.ts#L178.