Skip to content

missing params for resource path constructor #678

@xiaozhenliu-gg5

Description

@xiaozhenliu-gg5

For @google-cloud/kms path of some resources misses parameters, like keyRingPath it should be

  keyRingPath(project, location, keyRing) {
    return this._pathTemplates.keyRingPathTemplate.render({
      project: project,
      location: location,
      key_ring: keyRing,
    });
  }

but we got

  keyRingPath(project: string, location: string) {
    return this._pathTemplates.keyringPathTemplate.render({
      project,
      location,
    });
  }

and also that's why we don't miss some match function like:

  matchKeyRingFromKeyRingName(keyRingName) {
    return this._pathTemplates.keyRingPathTemplate.match(keyRingName).key_ring;
  }

Reference PR: googleapis/nodejs-kms#264

Metadata

Metadata

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions