-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
googleapis/gapic-generator-typescript
#206Labels
🚨This issue needs some love.This issue needs some love.triage meI really want to be triaged.I really want to be triaged.
Description
For @google-cloud/kms path of some resources misses parameters, like keyRingPath it should be
keyRingPath(project, location, keyRing) {
return this._pathTemplates.keyRingPathTemplate.render({
project: project,
location: location,
key_ring: keyRing,
});
}
but we got
keyRingPath(project: string, location: string) {
return this._pathTemplates.keyringPathTemplate.render({
project,
location,
});
}
and also that's why we don't miss some match function like:
matchKeyRingFromKeyRingName(keyRingName) {
return this._pathTemplates.keyRingPathTemplate.match(keyRingName).key_ring;
}
Reference PR: googleapis/nodejs-kms#264
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.triage meI really want to be triaged.I really want to be triaged.