feat!: move to typescript code generation by xiaozhenliu-gg5 · Pull Request #264 · googleapis/nodejs-kms

xiaozhenliu-gg5 · 2020-01-14T19:33:55Z

BREAKING CHANGE: helper function generated for resource gets changed, cryptoKeyPathPathTemplate is removed from Typescript client.

convert src/v1/kmsclient.js to Typescript, and manually add IamClient to the service. (by synth.py)
helper.ts creates the iamClient service and provides three methods getIamPolicy, setIamPolicy, testIamPermission for kms client.
Manually add extra_proto_list.json for extra Iam service protos.
Manually write iam_policy_service_client_config.json
Add unit test for three extra methods from IAM service.

codecov · 2020-01-14T22:44:25Z

Codecov Report

❗ No coverage uploaded for pull request base (master@89fc97b). Click here to learn what that means.
The diff coverage is 64.52%.

@@            Coverage Diff            @@
##             master     googleapis/gapic-generator-typescript#264   +/-   ##
=========================================
  Coverage          ?   86.55%           
=========================================
  Files             ?        4           
  Lines             ?     3205           
  Branches          ?      101           
=========================================
  Hits              ?     2774           
  Misses            ?      430           
  Partials          ?        1

Impacted Files	Coverage Δ
src/index.ts	`100% <100%> (ø)`
src/helper.ts	`28.07% <33.62%> (ø)`
src/v1/key_management_service_client.ts	`90.89% <80.56%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89fc97b...ceb08e9. Read the comment docs.

alexander-fenster

LGTM but let's first figure out the problem with the missing path template.

xiaozhenliu-gg5 · 2020-01-23T20:26:20Z

seems SetIamPolicy and GetIamPolicy is defined in googleapis/googleapis/google/cloud/kms/v1/cloudkms_gapic.yaml and it reroutes to google.iam.v1.IAMPolicy which is not supported by micro-generator now.

reroute_to_grpc_interface: google.iam.v1.IAMPolicy

For go, they add the rerouting methods manually to generated client code, [but in separate directory, or it will be rewritten by synthtool], can you give some suggestions here? @alexander-fenster Thanks

alexander-fenster · 2020-01-27T18:36:50Z

(replied in person, adding response here for documentation purposes)

I think we need to generate IAM client (in synth.py) and then mix-in IAM and KMS clients together, similar to how I did a mix-in in speech API.

tslint.json

webpack.config.js

helperMethods.txt

package.json

src/helper.ts

synth.py

tslint.json

alexander-fenster · 2020-03-04T08:32:08Z

@xiaozhenliu-gg5 Please update the PR message with some short description of what's changed (starting with BREAKING CHANGE line, as shown here).

helperMethods.ts.tmpl

package.json

src/helper.ts

JustinBeckwith

LGTM, but let @alexander-fenster give it the final look :)

synth.py

alexander-fenster

LGTM! 🎉

xiaozhenliu-gg5 added 3 commits January 14, 2020 10:47

update from synthtool

61ff6ef

move to typescript

9c36028

update synth script and run it

ccabf80

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2020

xiaozhenliu-gg5 mentioned this pull request Jan 14, 2020

feat: move library to typescript code generation #248

Closed

convert system-test to ts

b1e691b

xiaozhenliu-gg5 added 11 commits January 14, 2020 15:07

try this

d014a69

lint

1285e1e

regenerate to pick up change for path template

14620e7

update client

c217bce

gts fix

8ff218d

update copyright

a407828

2020 copyright

d9bfc93

try this

bab88f2

fix unit test

7a9045a

re-generate

155a66e

merge

fb2c869

xiaozhenliu-gg5 mentioned this pull request Nov 4, 2025

missing params for resource path constructor googleapis/google-cloud-node-core#678

Closed

make sample test work

e5b5fea

xiaozhenliu-gg5 mentioned this pull request Nov 4, 2025

missing path templates in kms googleapis/google-cloud-node-core#677

Closed

xiaozhenliu-gg5 added 2 commits January 22, 2020 23:05

remove sample test for IAM policy

82d649c

liny

888042d

xiaozhenliu-gg5 requested a review from alexander-fenster January 23, 2020 07:32

alexander-fenster suggested changes Jan 23, 2020

View reviewed changes

xiaozhenliu-gg5 added 3 commits January 28, 2020 16:03

remove doc, revert sample-test

42c2b5e

add iam client to kmsClient

e08a5f7

update sample-test

cd20228

alexander-fenster reviewed Mar 3, 2020

View reviewed changes

tslint.json Outdated Show resolved Hide resolved

alexander-fenster reviewed Mar 3, 2020

View reviewed changes

webpack.config.js Show resolved Hide resolved

alexander-fenster changed the title ~~feat: move to typescript code generation~~ feat!: move to typescript code generation Mar 3, 2020

feedback

c1eb1f1

JustinBeckwith suggested changes Mar 3, 2020

View reviewed changes

xiaozhenliu-gg5 added 5 commits March 3, 2020 16:57

update dependencies

1c9a5b8

license aligned for helper.ts

5f571e6

remove helper.ts, tslint from synth.py

d31d1f2

move script around

a74e752

add comments to iamclient & synth.py

971b293

xiaozhenliu-gg5 added 3 commits March 4, 2020 10:16

rename helperMethods.tmpl

5d649a2

rerun ynthtool

910346c

give auth the type

e32ca48

JustinBeckwith suggested changes Mar 4, 2020

View reviewed changes

helperMethods.ts.tmpl Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

src/helper.ts Show resolved Hide resolved

src/helper.ts Show resolved Hide resolved

xiaozhenliu-gg5 added 3 commits March 4, 2020 10:45

re set up scripts in package.json

1c86f39

add meaningful comment

2ddca33

add comments in helperMethods.tmpl

cb4d5bc

xiaozhenliu-gg5 requested review from JustinBeckwith and alexander-fenster March 4, 2020 19:07

JustinBeckwith approved these changes Mar 4, 2020

View reviewed changes

alexander-fenster reviewed Mar 4, 2020

View reviewed changes

synth.py Outdated Show resolved Hide resolved

xiaozhenliu-gg5 added 4 commits March 4, 2020 15:06

test

7a2db0c

import * as packagejson from ../package.json;

df571b2

remove any

bebc135

run synthtool

77fd144

xiaozhenliu-gg5 requested a review from alexander-fenster March 4, 2020 23:36

alexander-fenster approved these changes Mar 4, 2020

View reviewed changes

xiaozhenliu-gg5 merged commit ad02c1c into master Mar 5, 2020

release-please bot mentioned this pull request Mar 5, 2020

chore: release 2.0.0 #285

Merged

Conversation

xiaozhenliu-gg5 commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

alexander-fenster left a comment

Choose a reason for hiding this comment

Uh oh!

xiaozhenliu-gg5 commented Jan 23, 2020

Uh oh!

alexander-fenster commented Jan 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexander-fenster commented Mar 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JustinBeckwith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexander-fenster left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xiaozhenliu-gg5 commented Jan 14, 2020 •

edited

Loading

codecov bot commented Jan 14, 2020 •

edited

Loading