Skip to content

improper sample message in unit test #658

@xiaozhenliu-gg5

Description

@xiaozhenliu-gg5

In nodejs-logging, the generated unit test has improper sample message:

            const expectedResponse = [
              generateSampleMessage(new protosTYPE_STRING()),
              generateSampleMessage(new protosTYPE_STRING()),
              generateSampleMessage(new protosTYPE_STRING()),
            ];

which takes ENUM as a class to create an object, this is related to the template in util that actually checks if a type is a primitive type or a message, and substitutes the right thing.
ref: googleapis/nodejs-logging#778

Metadata

Metadata

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions