-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
googleapis/gapic-generator-typescript
#382Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
In nodejs-logging, the generated unit test has improper sample message:
const expectedResponse = [
generateSampleMessage(new protosTYPE_STRING()),
generateSampleMessage(new protosTYPE_STRING()),
generateSampleMessage(new protosTYPE_STRING()),
];
which takes ENUM as a class to create an object, this is related to the template in util that actually checks if a type is a primitive type or a message, and substitutes the right thing.
ref: googleapis/nodejs-logging#778
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.