feat!: drop node8 support, support for async iterators#778
feat!: drop node8 support, support for async iterators#778xiaozhenliu-gg5 merged 7 commits intomasterfrom
Conversation
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. New feature: methods with pagination now support async iteration.
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
===========================================
+ Coverage 87.32% 97.65% +10.32%
===========================================
Files 16 16
Lines 10244 10784 +540
Branches 362 364 +2
===========================================
+ Hits 8946 10531 +1585
+ Misses 1297 252 -1045
Partials 1 1
Continue to review full report at Codecov.
|
|
|
||
| it('should create a sink with a Dataset destination', async () => { | ||
| const sink = logging.sink(generateName()); | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
instead of the eslint disable, could have refactored the next line as const [, apiResponse] = ... (omit the _)
There was a problem hiding this comment.
thanks for the suggestion! Checking the fix out!
|
|
||
| describe('Entry', () => { | ||
| // tslint:disable-next-line no-any variable-name | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
what happened to the variable-name disable for the cap E in Entry within a let. do the linting rules no longer have this check?
There was a problem hiding this comment.
linter does not complain about the variable name, just checked the gts package, it might be related with this rule: "@typescript-eslint/camelcase": "off",?
There was a problem hiding this comment.
variable-name is now @typescript-eslint/naming-convention, see https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/ROADMAP.md#style
I've opened google/gts#486
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
New feature: methods with pagination now support async iteration.