datastore: properly parse HTTP responses from the API #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
19 tasks
lib/common/util.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
31615c5 to
8b2bbf2
Compare
callmehiphop
added a commit
that referenced
this pull request
Oct 14, 2015
…parsing datastore: properly parse HTTP responses from the API
Contributor
|
Thank you, sir! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
Source-Link: googleapis/synthtool@7751597 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:a1e45c1b53fceb5fa7fd5c49cf898048c210eb07001a3355548e7a4545200ee8 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910
The bug originally caught here by @electricFeel (thanks!) resulted in a re-factor, also bringing in some of the sane changes from #897 (the datastore v1beta3 upgrade).
PTAL asap, as we should get out a patch release as soon as possible.