Merged
Conversation
leahecole
reviewed
Oct 3, 2025
Comment on lines
+41
to
+44
| FAKE_DIRECTORY, | ||
| FAKE_DEST_DIRECTORY, | ||
| undefined, | ||
| true, |
Contributor
There was a problem hiding this comment.
maintainability nit: can these be passed as named parameters rather than positional ones so it's easier to know which value is which parameter?
| assert.match(contents, /..\/..\/protos\/protos.js/); | ||
| }); | ||
|
|
||
| it('should guess the default version if not provided', async () => { |
Contributor
There was a problem hiding this comment.
Why is this test removed?
Contributor
Author
There was a problem hiding this comment.
The functionality was moved to library.ts so it was moved to the library.test.ts file. The corresponding test is: should correctly initialize versions and clients if no default version is provided.
| return defaultVersionAndClients; | ||
| } | ||
|
|
||
| // In case a default version isn't provided, this function should |
Contributor
There was a problem hiding this comment.
nit - regular comment before more thorough docstring
packages/gapic-node-processing/test/fixtures/combined-library/google-cloud-tasks/package.json
Show resolved
Hide resolved
sofisl
added a commit
that referenced
this pull request
Oct 3, 2025
Contributor
Author
|
@leahecole this is ready for review, PTAL! |
leahecole
reviewed
Oct 7, 2025
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
leahecole
approved these changes
Oct 7, 2025
feywind
pushed a commit
that referenced
this pull request
Oct 7, 2025
…#6777) * chore: run compileProtos and update gapic-node-processing PiperOrigin-RevId: 813843285 Source-Link: googleapis/googleapis@c61d80b Source-Link: googleapis/googleapis-gen@e195618 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1ldGFzdG9yZS8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1pZ3JhdGlvbmNlbnRlci8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6ImUxOTU2MThlODVhZjdlNGEwOTJlNDQ5M2E1OGMyMWZkNDNkN2QxNDgifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5ldGFwcC8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5ldHdvcmtjb25uZWN0aXZpdHkvLk93bEJvdC55YW1sIiwiaCI6ImUxOTU2MThlODVhZjdlNGEwOTJlNDQ5M2E1OGMyMWZkNDNkN2QxNDgifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5ldHdvcmttYW5hZ2VtZW50Ly5Pd2xCb3QueWFtbCIsImgiOiJlMTk1NjE4ZTg1YWY3ZTRhMDkyZTQ0OTNhNThjMjFmZDQzZDdkMTQ4In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5ldHdvcmtzZWN1cml0eS8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5ldHdvcmtzZXJ2aWNlcy8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5vdGVib29rcy8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW9yYWNsZWRhdGFiYXNlLy5Pd2xCb3QueWFtbCIsImgiOiJlMTk1NjE4ZTg1YWY3ZTRhMDkyZTQ0OTNhNThjMjFmZDQzZDdkMTQ4In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW9yY2hlc3RyYXRpb24tYWlyZmxvdy1zZXJ2aWNlLy5Pd2xCb3QueWFtbCIsImgiOiJlMTk1NjE4ZTg1YWY3ZTRhMDkyZTQ0OTNhNThjMjFmZDQzZDdkMTQ4In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW9yZ3BvbGljeS8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW9zY29uZmlnLy5Pd2xCb3QueWFtbCIsImgiOiJlMTk1NjE4ZTg1YWY3ZTRhMDkyZTQ0OTNhNThjMjFmZDQzZDdkMTQ4In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW9zbG9naW4vLk93bEJvdC55YW1sIiwiaCI6ImUxOTU2MThlODVhZjdlNGEwOTJlNDQ5M2E1OGMyMWZkNDNkN2QxNDgifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXBhcmFsbGVsc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6ImUxOTU2MThlODVhZjdlNGEwOTJlNDQ5M2E1OGMyMWZkNDNkN2QxNDgifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXBhcmFtZXRlcm1hbmFnZXIvLk93bEJvdC55YW1sIiwiaCI6ImUxOTU2MThlODVhZjdlNGEwOTJlNDQ5M2E1OGMyMWZkNDNkN2QxNDgifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXBoaXNoaW5ncHJvdGVjdGlvbi8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXBvbGljeXNpbXVsYXRvci8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXBvbGljeXRyb3VibGVzaG9vdGVyLWlhbS8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXBvbGljeXRyb3VibGVzaG9vdGVyLy5Pd2xCb3QueWFtbCIsImgiOiJlMTk1NjE4ZTg1YWY3ZTRhMDkyZTQ0OTNhNThjMjFmZDQzZDdkMTQ4In0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: remove unmaintained file in networksecurity * chore: manually fix what will be fixed by #6784 * remove extra clients * fix typo * undo change to published name --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <sofialeon@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pre-PR for actual changes that I need. I'm refactoring the library so I can easily add a feature later on. For the time being, this merely consolidates all the library information into a library object.
Essentially we're moving a lot of target-library-specific information from the generate-index.ts command to a top-level library object so that we can use the information more globally.
The motivation for this PR is #6777. The test is failing because the system-test is testing all the clients in v1 - but not all those clients exist in v1beta1. Since the default version is still v1beta1, we need to test those clients, as opposed to the clients in v1. (separately, we should probably also upgrade this library). Basically this exposes the need to test the same clients in the default version, which means the clients and default version exposed globally vs. per function, hence the new library object.
I've tried to make as few changes as possible here so as to not break anything too much. I'll create a separate follow up PR putting more methods into the actual library object, for now we can just pass in the library object as is since it preserves functionality the best.