all: manage all outgoing requests in one place #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
f8436f5 to
5c51510
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
5c51510 to
97e4762
Compare
Contributor
Author
|
@ryanseys - cleaned up the makeAuthorizedRequest stuff -- it was badly broken. I hang my head :( stephenplusplus@cad6302 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Un-mergable but looks good enough for merge! |
Contributor
Author
|
Haha cool. I keep breaking my own prs! On Thursday, November 6, 2014, Ryan Seys notifications@github.com wrote:
|
cad6302 to
81aba40
Compare
Contributor
Author
|
Fixed the conflict. It's good to go, but I'll let it sit for a few in case @silvolu wants to take a looksee. |
Contributor
|
Silvano, merge when happy :) |
silvolu
added a commit
that referenced
this pull request
Nov 6, 2014
all: manage all outgoing requests in one place
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
This was referenced Nov 11, 2022
This was referenced Nov 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
…beta1` `batch_prediction_job.proto` (#278) * chore: update v2.14.2 gapic-generator-typescript Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add `service_account` to `BatchPredictionJob` in aiplatform `v1beta1` `batch_prediction_job.proto` PiperOrigin-RevId: 434935416 Source-Link: googleapis/googleapis@dfdd5ee Source-Link: googleapis/googleapis-gen@2774684 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjc3NDY4NGMzYjhiMjI2Mzk5MDk2ODhkMjk3ZDRmYTU5MWZkZTllYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
🤖 I have created a release *beep* *boop* --- ## [1.18.0](googleapis/nodejs-ai-platform@v1.17.0...v1.18.0) (2022-03-17) ### Features * add `service_account` to `BatchPredictionJob` in aiplatform `v1beta1` `batch_prediction_job.proto` ([#278](googleapis/nodejs-ai-platform#278)) ([1f05428](googleapis/nodejs-ai-platform@1f05428)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
This was referenced Oct 27, 2023
Open
This was referenced Dec 14, 2023
Open
This was referenced Jan 2, 2024
Open
Open
This was referenced Mar 15, 2024
Open
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
We use this at runtime. Fixes: googleapis/nodejs-logging-bunyan#277
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know, I know. Huge PR. I'm sorry :(
This depends on #276.
This gets rid of the connection module, and uses the abstracted google-service-account. I know we talked about bringing back support for pem files, so when that time comes, I can just add it in the gsa lib.