-
Notifications
You must be signed in to change notification settings - Fork 640
compute: implement InstanceGroups #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute: implement InstanceGroups #1320
Conversation
78248e9 to
1c8a342
Compare
|
@callmehiphop I originally had the type called |
|
I like InstanceGroup!
|
|
@callmehiphop Ready for a review, good sir. |
| * @param {string} options.pageToken - A previously-returned page token | ||
| * representing part of the larger set of results to view. | ||
| * @param {function} callback - The callback function. | ||
| * @param {?error} callback.err - An error returned while making this request. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
8ec4b35 to
1be1df5
Compare
|
@callmehiphop Done! |
|
@callmehiphop looks mergable to you? |
|
@stephenplusplus yeah, sorry, looks good! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/gax-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes https://github.com/googleapis/gax-nodejs/issues/1319 🦕
RE: #1073
To Dos
This adds support for instance groups: