datastore: base64 cursors#1209
Closed
mcfarljw wants to merge 3 commits intogoogleapis:masterfrom
mcfarljw:base64-cursors
Closed
datastore: base64 cursors#1209mcfarljw wants to merge 3 commits intogoogleapis:masterfrom mcfarljw:base64-cursors
mcfarljw wants to merge 3 commits intogoogleapis:masterfrom
mcfarljw:base64-cursors
Conversation
lib/datastore/request.js
Outdated
| if (nextQuery && nextQuery.endVal) { | ||
| // Convert endVal to base64 format | ||
| nextQuery.endVal = new Buffer(nextQuery.endVal).toString('base64'); | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Thanks for sending this in, you have been a huge help getting our Datastore support into good shape. 💪 |
Contributor
Author
|
No problem. Thanks for pointing out the global |
Contributor
|
Merged in a80ff9b -- thanks again for helping us out :) |
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Source-Link: googleapis/synthtool@b1ced7d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:0527a86c10b67742c409dc726ba9a31ec4e69b0006e3d7a49b0e6686c59cdaa9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
To fix recent protobuf errors based on googleapis/nodejs-pubsub#1085. Fixes #1209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1208
Not sure if this is the right way to handle it, but either way it could probably also use a test to prevent regressions in formatting going forward.